Re: [PATCH v3 16/18] hw/i386: Introduce EPYC mode function handlers

2020-01-29 Thread Eduardo Habkost
On Tue, Jan 28, 2020 at 03:48:15PM -0600, Babu Moger wrote: > On 1/28/20 2:04 PM, Eduardo Habkost wrote: [...] > > If you need a CPU model to provide special behavior, > > you have two options: > > > > * Add a method pointer to X86CPUClass and/or X86CPUDefinition > > * Add a QOM property to

Re: [PATCH v3 16/18] hw/i386: Introduce EPYC mode function handlers

2020-01-28 Thread Babu Moger
On 1/28/20 2:04 PM, Eduardo Habkost wrote: > Hi, > > Sorry for taking so long. I was away from the office for a > month, and now I'm finally back. no worries. > > On Tue, Dec 03, 2019 at 06:38:46PM -0600, Babu Moger wrote: >> Introduce following handlers for new epyc mode. >>

Re: [PATCH v3 16/18] hw/i386: Introduce EPYC mode function handlers

2020-01-28 Thread Eduardo Habkost
Hi, Sorry for taking so long. I was away from the office for a month, and now I'm finally back. On Tue, Dec 03, 2019 at 06:38:46PM -0600, Babu Moger wrote: > Introduce following handlers for new epyc mode. > x86_apicid_from_cpu_idx_epyc: Generate apicid from cpu index. >

[PATCH v3 16/18] hw/i386: Introduce EPYC mode function handlers

2019-12-03 Thread Babu Moger
Introduce following handlers for new epyc mode. x86_apicid_from_cpu_idx_epyc: Generate apicid from cpu index. x86_topo_ids_from_apicid_epyc: Generate topo ids from apic id. x86_apicid_from_topo_ids_epyc: Generate apicid from topo ids. Signed-off-by: Babu Moger --- hw/i386/pc.c |