Re: [PATCH v3 16/33] serial-mm: use sysbus facilities

2019-11-20 Thread Peter Maydell
On Wed, 20 Nov 2019 at 08:30, Marc-André Lureau wrote: > > Hi > > On Mon, Nov 18, 2019 at 7:09 PM Peter Maydell > wrote: > > Otherwise > > Reviewed-by: Peter Maydell > > Does your r-b stands if I keep "self"? Or do you feel strongly about it? Yes, I do strongly think you need to change that

Re: [PATCH v3 16/33] serial-mm: use sysbus facilities

2019-11-20 Thread Marc-André Lureau
Hi On Mon, Nov 18, 2019 at 7:09 PM Peter Maydell wrote: > > On Wed, 23 Oct 2019 at 18:34, Marc-André Lureau > wrote: > > > > Make SerialMM a regular sysbus device, by registering the irq, and the > > mmio region. Reexport the internal serial properties. > > > > Signed-off-by: Marc-André Lureau

Re: [PATCH v3 16/33] serial-mm: use sysbus facilities

2019-11-18 Thread Peter Maydell
On Wed, 23 Oct 2019 at 18:34, Marc-André Lureau wrote: > > Make SerialMM a regular sysbus device, by registering the irq, and the > mmio region. Reexport the internal serial properties. > > Signed-off-by: Marc-André Lureau > --- > hw/char/serial.c | 35 --- > 1

[PATCH v3 16/33] serial-mm: use sysbus facilities

2019-10-23 Thread Marc-André Lureau
Make SerialMM a regular sysbus device, by registering the irq, and the mmio region. Reexport the internal serial properties. Signed-off-by: Marc-André Lureau --- hw/char/serial.c | 35 --- 1 file changed, 24 insertions(+), 11 deletions(-) diff --git