Re: [PATCH v3 2/2] hw/acpi: Implement the SRAT GI affinity structure

2023-11-13 Thread Michael S. Tsirkin
On Mon, Nov 13, 2023 at 11:14:00AM +, Ankit Agrawal wrote: > > It also looks like this support just silently fails if the device > > string isn't the right type or isn't found. That's not good. Should > > the previous patch validate the device where the Error return is more > > readily availa

Re: [PATCH v3 2/2] hw/acpi: Implement the SRAT GI affinity structure

2023-11-13 Thread Ankit Agrawal
>> +    for (l = gi->nodelist; l; l = l->next) { >> +    PCIDeviceHandle dev_handle = {0}; >> +    PCIDevice *pci_dev = PCI_DEVICE(o); >> +    dev_handle.bdf = >> PCI_BUILD_BDF(pci_bus_num(pci_get_bus(pci_dev)), >> +  

Re: [PATCH v3 2/2] hw/acpi: Implement the SRAT GI affinity structure

2023-11-07 Thread Michael S. Tsirkin
On Wed, Nov 08, 2023 at 12:30:39AM +0530, ank...@nvidia.com wrote: > +for (l = gi->nodelist; l; l = l->next) { > +PCIDeviceHandle dev_handle = {0}; > +PCIDevice *pci_dev = PCI_DEVICE(o); > +dev_handle.bdf = PCI_BUILD_BDF(pci_bus_num(pci_get_bus(pci_dev)),

Re: [PATCH v3 2/2] hw/acpi: Implement the SRAT GI affinity structure

2023-11-07 Thread Michael S. Tsirkin
On Wed, Nov 08, 2023 at 12:30:39AM +0530, ank...@nvidia.com wrote: > From: Ankit Agrawal > > ACPI spec provides a scheme to associate "Generic Initiators" [1] > (e.g. heterogeneous processors and accelerators, GPUs, and I/O devices with > integrated compute or DMA engines GPUs) with Proximity Dom

Re: [PATCH v3 2/2] hw/acpi: Implement the SRAT GI affinity structure

2023-11-07 Thread Alex Williamson
On Wed, 8 Nov 2023 00:30:39 +0530 wrote: > From: Ankit Agrawal > > ACPI spec provides a scheme to associate "Generic Initiators" [1] > (e.g. heterogeneous processors and accelerators, GPUs, and I/O devices with > integrated compute or DMA engines GPUs) with Proximity Domains. This is > achieved

[PATCH v3 2/2] hw/acpi: Implement the SRAT GI affinity structure

2023-11-07 Thread ankita
From: Ankit Agrawal ACPI spec provides a scheme to associate "Generic Initiators" [1] (e.g. heterogeneous processors and accelerators, GPUs, and I/O devices with integrated compute or DMA engines GPUs) with Proximity Domains. This is achieved using Generic Initiator Affinity Structure in SRAT. Du