Re: [PATCH v3 2/2] hw/rtc/mc146818rtc: Convert to 3-phase reset (Resettable interface)

2021-05-03 Thread Edgar E. Iglesias
On Sun, May 02, 2021 at 06:39:31PM +0200, Philippe Mathieu-Daudé wrote: > TYPE_MC146818_RTC is an ISA device, so its DeviceClass::reset() > handler is called automatically when its qbus parent is reset > (we don't need to register it manually). > > We have 2 reset() methods: a generic one and the

[PATCH v3 2/2] hw/rtc/mc146818rtc: Convert to 3-phase reset (Resettable interface)

2021-05-02 Thread Philippe Mathieu-Daudé
TYPE_MC146818_RTC is an ISA device, so its DeviceClass::reset() handler is called automatically when its qbus parent is reset (we don't need to register it manually). We have 2 reset() methods: a generic one and the qdev one. Merge them into a reset_enter handler (keeping the IRQ lowering to a res