Re: [PATCH v3 2/3] Add dirty-sync-missed-zero-copy migration stat

2022-07-07 Thread Leonardo Brás
On Thu, 2022-07-07 at 15:56 -0400, Peter Xu wrote: > On Thu, Jul 07, 2022 at 04:50:47PM -0300, Leonardo Bras Soares Passos wrote: > > > I also think we should squash > > > patch 2/3 as patch 3 only started to provide meaningful values. > > > > IIRC Previously in zero-copy-send implementation, I wa

Re: [PATCH v3 2/3] Add dirty-sync-missed-zero-copy migration stat

2022-07-07 Thread Peter Xu
On Thu, Jul 07, 2022 at 04:50:47PM -0300, Leonardo Bras Soares Passos wrote: > > I also think we should squash > > patch 2/3 as patch 3 only started to provide meaningful values. > > IIRC Previously in zero-copy-send implementation, I was asked to keep the > property/capability in a separated patc

Re: [PATCH v3 2/3] Add dirty-sync-missed-zero-copy migration stat

2022-07-07 Thread Leonardo Bras Soares Passos
Hello Peter, On Thu, Jul 7, 2022 at 2:54 PM Peter Xu wrote: > > On Mon, Jul 04, 2022 at 05:23:14PM -0300, Leonardo Bras wrote: > > Signed-off-by: Leonardo Bras > > --- > > qapi/migration.json | 7 ++- > > migration/migration.c | 2 ++ > > monitor/hmp-cmds.c| 4 > > 3 files change

Re: [PATCH v3 2/3] Add dirty-sync-missed-zero-copy migration stat

2022-07-07 Thread Peter Xu
On Mon, Jul 04, 2022 at 05:23:14PM -0300, Leonardo Bras wrote: > Signed-off-by: Leonardo Bras > --- > qapi/migration.json | 7 ++- > migration/migration.c | 2 ++ > monitor/hmp-cmds.c| 4 > 3 files changed, 12 insertions(+), 1 deletion(-) > > diff --git a/qapi/migration.json b/qap

Re: [PATCH v3 2/3] Add dirty-sync-missed-zero-copy migration stat

2022-07-05 Thread Daniel P . Berrangé
On Mon, Jul 04, 2022 at 05:23:14PM -0300, Leonardo Bras wrote: > Signed-off-by: Leonardo Bras > --- > qapi/migration.json | 7 ++- > migration/migration.c | 2 ++ > monitor/hmp-cmds.c| 4 > 3 files changed, 12 insertions(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé With re

Re: [PATCH v3 2/3] Add dirty-sync-missed-zero-copy migration stat

2022-07-04 Thread Markus Armbruster
Leonardo Bras writes: > Signed-off-by: Leonardo Bras Acked-by: Markus Armbruster

[PATCH v3 2/3] Add dirty-sync-missed-zero-copy migration stat

2022-07-04 Thread Leonardo Bras
Signed-off-by: Leonardo Bras --- qapi/migration.json | 7 ++- migration/migration.c | 2 ++ monitor/hmp-cmds.c| 4 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/qapi/migration.json b/qapi/migration.json index 7102e474a6..fed08b9b88 100644 --- a/qapi/migration.json