RE: [PATCH v3 2/3] hw/i386: Add a new check to configure smp dies for EPYC

2020-08-13 Thread Babu Moger
> -Original Message- > From: Igor Mammedov > Sent: Thursday, August 13, 2020 8:56 AM > To: Moger, Babu > Cc: Daniel P. Berrangé ; ehabk...@redhat.com; > m...@redhat.com; qemu-devel@nongnu.org; pbonz...@redhat.com; > r...@twiddle.net > Subject: Re: [PATCH v3 2/3] hw/i386: Add a new

Re: [PATCH v3 2/3] hw/i386: Add a new check to configure smp dies for EPYC

2020-08-13 Thread Igor Mammedov
On Tue, 11 Aug 2020 16:03:58 -0500 Babu Moger wrote: > On 8/7/20 2:11 PM, Igor Mammedov wrote: > > On Fri, 7 Aug 2020 17:52:22 +0100 > > Daniel P. Berrangé wrote: > > > >> On Fri, Aug 07, 2020 at 11:32:51AM -0500, Babu Moger wrote: > >>> Adding a new check to warn the users to configure

Re: [PATCH v3 2/3] hw/i386: Add a new check to configure smp dies for EPYC

2020-08-11 Thread Babu Moger
On 8/7/20 2:11 PM, Igor Mammedov wrote: > On Fri, 7 Aug 2020 17:52:22 +0100 > Daniel P. Berrangé wrote: > >> On Fri, Aug 07, 2020 at 11:32:51AM -0500, Babu Moger wrote: >>> Adding a new check to warn the users to configure 'dies' when >>> topology is numa configured. It makes it easy to build

RE: [PATCH v3 2/3] hw/i386: Add a new check to configure smp dies for EPYC

2020-08-11 Thread Babu Moger
> -Original Message- > From: Igor Mammedov > Sent: Friday, August 7, 2020 2:27 PM > To: Moger, Babu > Cc: pbonz...@redhat.com; r...@twiddle.net; ehabk...@redhat.com; qemu- > de...@nongnu.org; m...@redhat.com > Subject: Re: [PATCH v3 2/3] hw/i386: Add a new check to configure smp dies

Re: [PATCH v3 2/3] hw/i386: Add a new check to configure smp dies for EPYC

2020-08-07 Thread Igor Mammedov
On Fri, 07 Aug 2020 11:32:51 -0500 Babu Moger wrote: > Adding a new check to warn the users to configure 'dies' when s/warn .../error out .../ > topology is numa configured. It makes it easy to build the > topology for EPYC models. probably it should mention that will break configs that do not

Re: [PATCH v3 2/3] hw/i386: Add a new check to configure smp dies for EPYC

2020-08-07 Thread Igor Mammedov
On Fri, 7 Aug 2020 17:52:22 +0100 Daniel P. Berrangé wrote: > On Fri, Aug 07, 2020 at 11:32:51AM -0500, Babu Moger wrote: > > Adding a new check to warn the users to configure 'dies' when > > topology is numa configured. It makes it easy to build the > > topology for EPYC models. > > This

Re: [PATCH v3 2/3] hw/i386: Add a new check to configure smp dies for EPYC

2020-08-07 Thread Babu Moger
On 8/7/20 11:52 AM, Daniel P. Berrangé wrote: > On Fri, Aug 07, 2020 at 11:32:51AM -0500, Babu Moger wrote: >> Adding a new check to warn the users to configure 'dies' when >> topology is numa configured. It makes it easy to build the >> topology for EPYC models. > > This says you're adding a

Re: [PATCH v3 2/3] hw/i386: Add a new check to configure smp dies for EPYC

2020-08-07 Thread Daniel P . Berrangé
On Fri, Aug 07, 2020 at 11:32:51AM -0500, Babu Moger wrote: > Adding a new check to warn the users to configure 'dies' when > topology is numa configured. It makes it easy to build the > topology for EPYC models. This says you're adding a warning > > Signed-off-by: Babu Moger > --- >

[PATCH v3 2/3] hw/i386: Add a new check to configure smp dies for EPYC

2020-08-07 Thread Babu Moger
Adding a new check to warn the users to configure 'dies' when topology is numa configured. It makes it easy to build the topology for EPYC models. Signed-off-by: Babu Moger --- hw/i386/x86.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/i386/x86.c b/hw/i386/x86.c index