Re: [PATCH v3 2/3] ui: Deliver refresh rate via QemuUIInfo

2022-06-09 Thread Gerd Hoffmann
Hi, > > > > (1) add refresh_rate > > > > (2) update users one by one > > > > (3) finally drop update_interval when no user is left. > > > > > > > > thanks, > > > > Gerd > > > > > > > > > > I think 1 and 3 should have to be done once since refresh_rate and > > > update_interval would inter

Re: [PATCH v3 2/3] ui: Deliver refresh rate via QemuUIInfo

2022-06-09 Thread Akihiko Odaki
On 2022/06/09 21:02, Gerd Hoffmann wrote: On Thu, Jun 09, 2022 at 08:45:41PM +0900, Akihiko Odaki wrote: On 2022/06/09 19:28, Gerd Hoffmann wrote: --- a/include/ui/console.h +++ b/include/ui/console.h @@ -139,6 +139,7 @@ typedef struct QemuUIInfo { int yoff; uint32_t width;

Re: [PATCH v3 2/3] ui: Deliver refresh rate via QemuUIInfo

2022-06-09 Thread Gerd Hoffmann
On Thu, Jun 09, 2022 at 08:45:41PM +0900, Akihiko Odaki wrote: > On 2022/06/09 19:28, Gerd Hoffmann wrote: > > > --- a/include/ui/console.h > > > +++ b/include/ui/console.h > > > @@ -139,6 +139,7 @@ typedef struct QemuUIInfo { > > > int yoff; > > > uint32_t width; > > > uin

Re: [PATCH v3 2/3] ui: Deliver refresh rate via QemuUIInfo

2022-06-09 Thread Akihiko Odaki
On 2022/06/09 19:28, Gerd Hoffmann wrote: --- a/include/ui/console.h +++ b/include/ui/console.h @@ -139,6 +139,7 @@ typedef struct QemuUIInfo { int yoff; uint32_t width; uint32_t height; +uint32_t refresh_rate; } QemuUIInfo; /* cursor data format is 32bit RGB

Re: [PATCH v3 2/3] ui: Deliver refresh rate via QemuUIInfo

2022-06-09 Thread Gerd Hoffmann
> --- a/include/ui/console.h > +++ b/include/ui/console.h > @@ -139,6 +139,7 @@ typedef struct QemuUIInfo { > int yoff; > uint32_t width; > uint32_t height; > +uint32_t refresh_rate; > } QemuUIInfo; > > /* cursor data format is 32bit RGBA */ > @@ -426,7 +427,6 @@ typ

[PATCH v3 2/3] ui: Deliver refresh rate via QemuUIInfo

2022-02-26 Thread Akihiko Odaki
This change adds a new member, refresh_rate to QemuUIInfo in include/ui/console.h. It represents the refresh rate of the physical display backend, and it is more appropriate than GUI update interval as the refresh rate which the emulated device reports: - sdl may set GUI update interval shorter tha