Re: [PATCH v3 2/3] vhost: Remove vhost_backend_can_merge() callback

2023-05-23 Thread Peter Xu
On Wed, May 03, 2023 at 07:21:20PM +0200, David Hildenbrand wrote: > Checking whether the memory regions are equal is sufficient: if they are > equal, then most certainly the contained fd is equal. Looks reasonable to me. I double checked the src of the change and there's no bug report attached

[PATCH v3 2/3] vhost: Remove vhost_backend_can_merge() callback

2023-05-03 Thread David Hildenbrand
Checking whether the memory regions are equal is sufficient: if they are equal, then most certainly the contained fd is equal. The whole vhost-user memslot handling is suboptimal and overly complicated. We shouldn't have to lookup a RAM memory regions we got notified about in