Re: [PATCH v3 2/6] blockdev: combine DriveBackupState and BlockdevBackupState

2020-06-22 Thread Eric Blake
On 6/22/20 12:12 AM, Vladimir Sementsov-Ogievskiy wrote: 19.06.2020 22:56, Eric Blake wrote: From: John Snow They have the same fields -- rename it BlockJobActionState. commit/abort/clean functions are identical after it. I think better to combine them as well here I'll give it a shot in

Re: [PATCH v3 2/6] blockdev: combine DriveBackupState and BlockdevBackupState

2020-06-21 Thread Vladimir Sementsov-Ogievskiy
19.06.2020 22:56, Eric Blake wrote: From: John Snow They have the same fields -- rename it BlockJobActionState. commit/abort/clean functions are identical after it. I think better to combine them as well here Signed-off-by: John Snow Signed-off-by: Eric Blake --- blockdev.c | 30 +

[PATCH v3 2/6] blockdev: combine DriveBackupState and BlockdevBackupState

2020-06-19 Thread Eric Blake
From: John Snow They have the same fields -- rename it BlockJobActionState. Signed-off-by: John Snow Signed-off-by: Eric Blake --- blockdev.c | 30 -- 1 file changed, 12 insertions(+), 18 deletions(-) diff --git a/blockdev.c b/blockdev.c index 72df193ca73b..6d80af