Re: [PATCH v3 2/9] hw/i2c: pmbus: guard against out of range accesses

2022-03-07 Thread Titus Rwantare
Ack. All errors for PMBus should ideally be reflected in status and status_cml registers instead of carrying meaning in return values. I'll have to separately go through the existing code to make it consistent. On Fri, 4 Mar 2022 at 16:08, Philippe Mathieu-Daudé wrote: > > On 2/3/22 02:50, Titus

Re: [PATCH v3 2/9] hw/i2c: pmbus: guard against out of range accesses

2022-03-04 Thread Philippe Mathieu-Daudé
On 2/3/22 02:50, Titus Rwantare wrote: Signed-off-by: Titus Rwantare --- hw/i2c/pmbus_device.c | 41 - 1 file changed, 40 insertions(+), 1 deletion(-) static uint8_t pmbus_receive_byte(SMBusDevice *smd) { PMBusDevice *pmdev = PMBUS_DEVICE(s

[PATCH v3 2/9] hw/i2c: pmbus: guard against out of range accesses

2022-03-01 Thread Titus Rwantare
Signed-off-by: Titus Rwantare --- hw/i2c/pmbus_device.c | 41 - 1 file changed, 40 insertions(+), 1 deletion(-) diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c index 07a45c99f9..93c746bab3 100644 --- a/hw/i2c/pmbus_device.c +++ b/hw/i2c/pmbus_de