Re: [PATCH v3 21/33] lance: replace PROP_PTR with PROP_LINK

2019-10-25 Thread Peter Maydell
On Thu, 24 Oct 2019 at 19:07, Eduardo Habkost wrote: > On Thu, Oct 24, 2019 at 12:52:28PM +0100, Peter Maydell wrote: > > I don't think this is a good plan -- users shouldn't have to know > > about the memory map of their boards. Plus it doesn't deal with > > the complications of multiple address

Re: [PATCH v3 21/33] lance: replace PROP_PTR with PROP_LINK

2019-10-24 Thread Eduardo Habkost
On Thu, Oct 24, 2019 at 12:52:28PM +0100, Peter Maydell wrote: > On Thu, 24 Oct 2019 at 12:48, Philippe Mathieu-Daudé > wrote: > > Just wondering, if we had a "bus_address" property to the abstract > > SysBus class (and eventually "bus_name" for later) we could create/map > > sysbus devices from

Re: [PATCH v3 21/33] lance: replace PROP_PTR with PROP_LINK

2019-10-24 Thread Peter Maydell
On Thu, 24 Oct 2019 at 12:48, Philippe Mathieu-Daudé wrote: > Just wondering, if we had a "bus_address" property to the abstract > SysBus class (and eventually "bus_name" for later) we could create/map > sysbus devices from command line? I don't think this is a good plan -- users shouldn't have

Re: [PATCH v3 21/33] lance: replace PROP_PTR with PROP_LINK

2019-10-24 Thread Marc-André Lureau
On Thu, Oct 24, 2019 at 2:17 PM Philippe Mathieu-Daudé wrote: > > On 10/24/19 1:09 PM, Marc-André Lureau wrote: > > Hi > > > > > > On Thu, Oct 24, 2019 at 1:01 AM Philippe Mathieu-Daudé > > wrote: > >> > >> On 10/23/19 7:31 PM, Marc-André Lureau wrote: > >>> Signed-off-by: Marc-André Lureau >

Re: [PATCH v3 21/33] lance: replace PROP_PTR with PROP_LINK

2019-10-24 Thread Philippe Mathieu-Daudé
On 10/24/19 1:09 PM, Marc-André Lureau wrote: Hi On Thu, Oct 24, 2019 at 1:01 AM Philippe Mathieu-Daudé wrote: On 10/23/19 7:31 PM, Marc-André Lureau wrote: Signed-off-by: Marc-André Lureau Reviewed-by: Peter Maydell --- hw/dma/sparc32_dma.c | 2 +- hw/net/lance.c | 5 ++---

Re: [PATCH v3 21/33] lance: replace PROP_PTR with PROP_LINK

2019-10-24 Thread Marc-André Lureau
Hi On Thu, Oct 24, 2019 at 1:01 AM Philippe Mathieu-Daudé wrote: > > On 10/23/19 7:31 PM, Marc-André Lureau wrote: > > Signed-off-by: Marc-André Lureau > > Reviewed-by: Peter Maydell > > --- > > hw/dma/sparc32_dma.c | 2 +- > > hw/net/lance.c | 5 ++--- > > hw/net/pcnet-pci.c | 2

Re: [PATCH v3 21/33] lance: replace PROP_PTR with PROP_LINK

2019-10-23 Thread Philippe Mathieu-Daudé
On 10/23/19 7:31 PM, Marc-André Lureau wrote: Signed-off-by: Marc-André Lureau Reviewed-by: Peter Maydell --- hw/dma/sparc32_dma.c | 2 +- hw/net/lance.c | 5 ++--- hw/net/pcnet-pci.c | 2 +- hw/net/pcnet.h | 2 +- 4 files changed, 5 insertions(+), 6 deletions(-) diff

[PATCH v3 21/33] lance: replace PROP_PTR with PROP_LINK

2019-10-23 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau Reviewed-by: Peter Maydell --- hw/dma/sparc32_dma.c | 2 +- hw/net/lance.c | 5 ++--- hw/net/pcnet-pci.c | 2 +- hw/net/pcnet.h | 2 +- 4 files changed, 5 insertions(+), 6 deletions(-) diff --git a/hw/dma/sparc32_dma.c b/hw/dma/sparc32_dma.c index