Re: [PATCH v3 25/46] hw/net/smc91c111: use qemu_configure_nic_device()

2024-01-26 Thread David Woodhouse
On Fri, 2024-01-26 at 16:14 +0100, Thomas Huth wrote: > > >    /* Legacy helper function.  Should go away when machine config files are > >   implemented.  */ > > -void smc91c111_init(NICInfo *nd, uint32_t base, qemu_irq irq) > > +void smc91c111_init(uint32_t base, qemu_irq irq) > >    { > >  

Re: [PATCH v3 25/46] hw/net/smc91c111: use qemu_configure_nic_device()

2024-01-26 Thread Thomas Huth
On 08/01/2024 21.26, David Woodhouse wrote: From: David Woodhouse Some callers instantiate the device unconditionally, others will do so only if there is a NICInfo to go with it. This appears to be fairly random, but preserve the existing behaviour for now. Signed-off-by: David Woodhouse ---

[PATCH v3 25/46] hw/net/smc91c111: use qemu_configure_nic_device()

2024-01-08 Thread David Woodhouse
From: David Woodhouse Some callers instantiate the device unconditionally, others will do so only if there is a NICInfo to go with it. This appears to be fairly random, but preserve the existing behaviour for now. Signed-off-by: David Woodhouse --- hw/arm/gumstix.c | 6 ++ hw/ar