Re: [PATCH v3 3/3] meson: Drop the .fa library prefix

2024-05-24 Thread Akihiko Odaki
On 2024/05/22 22:45, Paolo Bonzini wrote: On Wed, May 22, 2024 at 12:49 PM Akihiko Odaki wrote: The non-standard .fa library prefix breaks the link source de-duplication done by Meson so drop it. Can you show the difference in the command lines? Without this patch: clang -o qemu-io qemu-io

Re: [PATCH v3 3/3] meson: Drop the .fa library prefix

2024-05-22 Thread Paolo Bonzini
On Wed, May 22, 2024 at 3:45 PM Paolo Bonzini wrote: > > On Wed, May 22, 2024 at 12:49 PM Akihiko Odaki > wrote: > > The non-standard .fa library prefix breaks the link source > > de-duplication done by Meson so drop it. > > Can you show the difference in the command lines? > > One possibility t

Re: [PATCH v3 3/3] meson: Drop the .fa library prefix

2024-05-22 Thread Paolo Bonzini
On Wed, May 22, 2024 at 12:49 PM Akihiko Odaki wrote: > The non-standard .fa library prefix breaks the link source > de-duplication done by Meson so drop it. Can you show the difference in the command lines? One possibility to force de-duplication of objects is to change "link_whole: foo" to "ob

[PATCH v3 3/3] meson: Drop the .fa library prefix

2024-05-22 Thread Akihiko Odaki
The non-standard .fa library prefix breaks the link source de-duplication done by Meson so drop it. The lack of link source de-duplication causes AddressSanitizer to complain ODR violations, and makes GNU ld abort when combined with clang's LTO. Previously, the non-standard prefix was necessary f