Re: [PATCH v3 3/3] multifd: Send using asynchronous write on nocomp to send RAM pages.

2021-09-29 Thread Leonardo Bras Soares Passos
On Tue, Sep 28, 2021 at 7:49 PM Peter Xu wrote: > > On Fri, Sep 24, 2021 at 06:43:49PM +0100, Daniel P. Berrangé wrote: > > > @@ -546,6 +546,7 @@ void multifd_save_cleanup(void) > > > MultiFDSendParams *p = &multifd_send_state->params[i]; > > > Error *local_err = NULL; > > > > >

Re: [PATCH v3 3/3] multifd: Send using asynchronous write on nocomp to send RAM pages.

2021-09-29 Thread Leonardo Bras Soares Passos
On Fri, Sep 24, 2021 at 2:44 PM Daniel P. Berrangé wrote: > > On Wed, Sep 22, 2021 at 07:24:23PM -0300, Leonardo Bras wrote: > > Change multifd nocomp version to use asynchronous write for RAM pages, and > > benefit of MSG_ZEROCOPY when it's available. > > > > The asynchronous flush happens on cle

Re: [PATCH v3 3/3] multifd: Send using asynchronous write on nocomp to send RAM pages.

2021-09-28 Thread Peter Xu
On Fri, Sep 24, 2021 at 06:43:49PM +0100, Daniel P. Berrangé wrote: > > @@ -546,6 +546,7 @@ void multifd_save_cleanup(void) > > MultiFDSendParams *p = &multifd_send_state->params[i]; > > Error *local_err = NULL; > > > > +qio_channel_async_flush(p->c, NULL); > >

Re: [PATCH v3 3/3] multifd: Send using asynchronous write on nocomp to send RAM pages.

2021-09-24 Thread Daniel P . Berrangé
On Wed, Sep 22, 2021 at 07:24:23PM -0300, Leonardo Bras wrote: > Change multifd nocomp version to use asynchronous write for RAM pages, and > benefit of MSG_ZEROCOPY when it's available. > > The asynchronous flush happens on cleanup only, before destroying the > QIOChannel. > > This will work fi

[PATCH v3 3/3] multifd: Send using asynchronous write on nocomp to send RAM pages.

2021-09-22 Thread Leonardo Bras
Change multifd nocomp version to use asynchronous write for RAM pages, and benefit of MSG_ZEROCOPY when it's available. The asynchronous flush happens on cleanup only, before destroying the QIOChannel. This will work fine on RAM migration because the RAM pages are not usually freed, and there i