Re: [PATCH v3 3/3] qapi: Allow introspecting fix for savevm's cooperation with blockdev

2019-10-10 Thread Eric Blake
On 10/10/19 6:05 AM, Peter Krempa wrote: In addition to Markus' review, 'savevm' was buggy as it considered all monitor-owned block device nodes for snapshot. With introduction of -blockdev the common usage made all With the introduction of -blockdev, the common usage nodes including

Re: [PATCH v3 3/3] qapi: Allow introspecting fix for savevm's cooperation with blockdev

2019-10-10 Thread Markus Armbruster
Peter Krempa writes: > 'savevm' was buggy as it considered all monitor-owned block device nodes > for snapshot. With introduction of -blockdev the common usage made all > nodes including protocol and backing file nodes monitor-owned and thus > considered for snapshot. > > This is a problem since

[PATCH v3 3/3] qapi: Allow introspecting fix for savevm's cooperation with blockdev

2019-10-10 Thread Peter Krempa
'savevm' was buggy as it considered all monitor-owned block device nodes for snapshot. With introduction of -blockdev the common usage made all nodes including protocol and backing file nodes monitor-owned and thus considered for snapshot. This is a problem since the 'file' protocol nodes can't