Re: [PATCH v3 3/3] target/arm: Use clear_vec_high more effectively

2020-05-08 Thread Philippe Mathieu-Daudé
On Tue, May 5, 2020 at 4:22 PM Richard Henderson wrote: > > On 5/4/20 11:09 PM, Philippe Mathieu-Daudé wrote: > >> @@ -7111,7 +7121,7 @@ static void disas_simd_zip_trn > >> } > >> tcg_resl = tcg_const_i64(0); > >> -tcg_resh = tcg_const_i64(0); > >> +tcg_resh = is_q ?

Re: [PATCH v3 3/3] target/arm: Use clear_vec_high more effectively

2020-05-05 Thread Richard Henderson
On 5/4/20 11:09 PM, Philippe Mathieu-Daudé wrote: >> @@ -7111,7 +7121,7 @@ static void disas_simd_zip_trn >>   } >>     tcg_resl = tcg_const_i64(0); >> -    tcg_resh = tcg_const_i64(0); >> +    tcg_resh = is_q ? tcg_const_i64(0) : NULL; >>   tcg_res = tcg_temp_new_i64(); >>     for

Re: [PATCH v3 3/3] target/arm: Use clear_vec_high more effectively

2020-05-05 Thread Philippe Mathieu-Daudé
On 5/4/20 9:23 PM, Richard Henderson wrote: Do not explicitly store zero to the NEON high part when we can pass !is_q to clear_vec_high. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- Patch easier to review with 'git-diff --function-context'. target/arm/translate-a64.c |

[PATCH v3 3/3] target/arm: Use clear_vec_high more effectively

2020-05-04 Thread Richard Henderson
Do not explicitly store zero to the NEON high part when we can pass !is_q to clear_vec_high. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 59 +++--- 1 file changed, 36 insertions(+), 23 deletions(-) diff --git