Re: [PATCH v3 3/7] hw/misc/led: Emit a trace event when LED intensity has changed

2020-06-23 Thread Philippe Mathieu-Daudé
On 6/22/20 6:48 PM, Richard Henderson wrote: > On 6/21/20 3:25 PM, Philippe Mathieu-Daudé wrote: >> Anyway I switched to a percent value. What is better to hold >> it, an 'unsigned' or 'uint8_t' type? > > Might as well use unsigned; you'll not be saving space with uint8_t. Bah if we want to migra

Re: [PATCH v3 3/7] hw/misc/led: Emit a trace event when LED intensity has changed

2020-06-22 Thread Richard Henderson
On 6/21/20 3:25 PM, Philippe Mathieu-Daudé wrote: > Anyway I switched to a percent value. What is better to hold > it, an 'unsigned' or 'uint8_t' type? Might as well use unsigned; you'll not be saving space with uint8_t. r~

Re: [PATCH v3 3/7] hw/misc/led: Emit a trace event when LED intensity has changed

2020-06-21 Thread Philippe Mathieu-Daudé
On 6/21/20 9:23 PM, Richard Henderson wrote: > On 6/20/20 4:07 PM, Philippe Mathieu-Daudé wrote: >> Track the LED intensity, and emit a trace event when it changes. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> include/hw/misc/led.h | 1 + >> hw/misc/led.c | 5 + >> hw/misc/tr

Re: [PATCH v3 3/7] hw/misc/led: Emit a trace event when LED intensity has changed

2020-06-21 Thread Richard Henderson
On 6/20/20 4:07 PM, Philippe Mathieu-Daudé wrote: > Track the LED intensity, and emit a trace event when it changes. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/misc/led.h | 1 + > hw/misc/led.c | 5 + > hw/misc/trace-events | 1 + > 3 files changed, 7 insertions(+)

[PATCH v3 3/7] hw/misc/led: Emit a trace event when LED intensity has changed

2020-06-20 Thread Philippe Mathieu-Daudé
Track the LED intensity, and emit a trace event when it changes. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/misc/led.h | 1 + hw/misc/led.c | 5 + hw/misc/trace-events | 1 + 3 files changed, 7 insertions(+) diff --git a/include/hw/misc/led.h b/include/hw/misc/led.h index