Re: [PATCH v3 4/5] coroutine: Split qemu/coroutine-core.h off qemu/coroutine.h

2022-12-22 Thread Paolo Bonzini
On 12/22/22 09:56, Markus Armbruster wrote: +/** + * Mark a function that executes in coroutine context + * + * + * Functions that execute in coroutine context cannot be called + * directly from normal functions. Use @coroutine_fn to mark such + * functions. For example: + * + * static void c

Re: [PATCH v3 4/5] coroutine: Split qemu/coroutine-core.h off qemu/coroutine.h

2022-12-22 Thread Markus Armbruster
Paolo Bonzini writes: > On 12/21/22 14:14, Markus Armbruster wrote: >> +/** >> + * Mark a function that executes in coroutine context >> + * >> + * >> + * Functions that execute in coroutine context cannot be called >> + * directly from normal functions. Use @coroutine_fn to mark such >> + * fun

Re: [PATCH v3 4/5] coroutine: Split qemu/coroutine-core.h off qemu/coroutine.h

2022-12-22 Thread Paolo Bonzini
On 12/21/22 14:14, Markus Armbruster wrote: +/** + * Mark a function that executes in coroutine context + * + * + * Functions that execute in coroutine context cannot be called + * directly from normal functions. Use @coroutine_fn to mark such + * functions. For example: + * + * static void c

[PATCH v3 4/5] coroutine: Split qemu/coroutine-core.h off qemu/coroutine.h

2022-12-21 Thread Markus Armbruster
qemu/coroutine.h and qemu/lockable.h include each other. They need each other only in macro expansions, so we could simply drop both inclusions to break the loop, and add suitable includes to files that expand the macros. Instead, move a part of qemu/coroutine.h to new qemu/coroutine-core.h so th