Re: [PATCH v3 4/8] target/ppc: add vmulld instruction

2020-06-25 Thread Richard Henderson
On 6/25/20 2:13 PM, Lijun Pan wrote: >>> case INDEX_op_mul_vec: >>> -    tcg_debug_assert(vece == MO_32 && have_isa_2_07); >>> -    insn = VMULUWM; >>> +    tcg_debug_assert((vece == MO_32 && have_isa_2_07) || >>> + (vece == MO_64 && have_isa_3_10)); >>> +   

Re: [PATCH v3 4/8] target/ppc: add vmulld instruction

2020-06-25 Thread Lijun Pan
> On Jun 25, 2020, at 1:25 PM, Richard Henderson > wrote: > > On 6/25/20 10:00 AM, Lijun Pan wrote: >> vmulld: Vector Multiply Low Doubleword. >> >> Signed-off-by: Lijun Pan >> --- >> v3: use tcg_gen_gvec_mul() >> >> target/ppc/translate/vmx-impl.inc.c | 1 + >> target/ppc/translate/vmx-ops.

Re: [PATCH v3 4/8] target/ppc: add vmulld instruction

2020-06-25 Thread Richard Henderson
On 6/25/20 10:00 AM, Lijun Pan wrote: > vmulld: Vector Multiply Low Doubleword. > > Signed-off-by: Lijun Pan > --- > v3: use tcg_gen_gvec_mul() > > target/ppc/translate/vmx-impl.inc.c | 1 + > target/ppc/translate/vmx-ops.inc.c | 4 This part looks fine. > tcg/ppc/tcg-target.h

[PATCH v3 4/8] target/ppc: add vmulld instruction

2020-06-25 Thread Lijun Pan
vmulld: Vector Multiply Low Doubleword. Signed-off-by: Lijun Pan --- v3: use tcg_gen_gvec_mul() target/ppc/translate/vmx-impl.inc.c | 1 + target/ppc/translate/vmx-ops.inc.c | 4 tcg/ppc/tcg-target.h| 2 ++ tcg/ppc/tcg-target.inc.c| 7 +-- 4 files changed,