Re: [PATCH v3 5/5] vdpa: move CVQ isolation check to net_init_vhost_vdpa

2023-05-18 Thread Eugenio Perez Martin
On Thu, May 18, 2023 at 11:23 PM Michael S. Tsirkin wrote: > > On Thu, May 18, 2023 at 08:36:22AM +0200, Eugenio Perez Martin wrote: > > On Thu, May 18, 2023 at 7:50 AM Jason Wang wrote: > > > > > > On Wed, May 17, 2023 at 2:30 PM Eugenio Perez Martin > > > wrote: > > > > > > > > On Wed, May

Re: [PATCH v3 5/5] vdpa: move CVQ isolation check to net_init_vhost_vdpa

2023-05-18 Thread Michael S. Tsirkin
On Thu, May 18, 2023 at 08:36:22AM +0200, Eugenio Perez Martin wrote: > On Thu, May 18, 2023 at 7:50 AM Jason Wang wrote: > > > > On Wed, May 17, 2023 at 2:30 PM Eugenio Perez Martin > > wrote: > > > > > > On Wed, May 17, 2023 at 5:59 AM Jason Wang wrote: > > > > > > > > On Tue, May 9, 2023 at

Re: [PATCH v3 5/5] vdpa: move CVQ isolation check to net_init_vhost_vdpa

2023-05-18 Thread Jason Wang
On Thu, May 18, 2023 at 2:37 PM Eugenio Perez Martin wrote: > > On Thu, May 18, 2023 at 7:50 AM Jason Wang wrote: > > > > On Wed, May 17, 2023 at 2:30 PM Eugenio Perez Martin > > wrote: > > > > > > On Wed, May 17, 2023 at 5:59 AM Jason Wang wrote: > > > > > > > > On Tue, May 9, 2023 at 11:44 

Re: [PATCH v3 5/5] vdpa: move CVQ isolation check to net_init_vhost_vdpa

2023-05-18 Thread Eugenio Perez Martin
On Thu, May 18, 2023 at 7:50 AM Jason Wang wrote: > > On Wed, May 17, 2023 at 2:30 PM Eugenio Perez Martin > wrote: > > > > On Wed, May 17, 2023 at 5:59 AM Jason Wang wrote: > > > > > > On Tue, May 9, 2023 at 11:44 PM Eugenio Pérez wrote: > > > > > > > > Evaluating it at start time instead of

Re: [PATCH v3 5/5] vdpa: move CVQ isolation check to net_init_vhost_vdpa

2023-05-17 Thread Jason Wang
On Wed, May 17, 2023 at 2:30 PM Eugenio Perez Martin wrote: > > On Wed, May 17, 2023 at 5:59 AM Jason Wang wrote: > > > > On Tue, May 9, 2023 at 11:44 PM Eugenio Pérez wrote: > > > > > > Evaluating it at start time instead of initialization time may make the > > > guest capable of dynamically

Re: [PATCH v3 5/5] vdpa: move CVQ isolation check to net_init_vhost_vdpa

2023-05-17 Thread Eugenio Perez Martin
On Wed, May 17, 2023 at 5:59 AM Jason Wang wrote: > > On Tue, May 9, 2023 at 11:44 PM Eugenio Pérez wrote: > > > > Evaluating it at start time instead of initialization time may make the > > guest capable of dynamically adding or removing migration blockers. > > > > Also, moving to

Re: [PATCH v3 5/5] vdpa: move CVQ isolation check to net_init_vhost_vdpa

2023-05-16 Thread Jason Wang
On Tue, May 9, 2023 at 11:44 PM Eugenio Pérez wrote: > > Evaluating it at start time instead of initialization time may make the > guest capable of dynamically adding or removing migration blockers. > > Also, moving to initialization reduces the number of ioctls in the > migration, reducing

[PATCH v3 5/5] vdpa: move CVQ isolation check to net_init_vhost_vdpa

2023-05-09 Thread Eugenio Pérez
Evaluating it at start time instead of initialization time may make the guest capable of dynamically adding or removing migration blockers. Also, moving to initialization reduces the number of ioctls in the migration, reducing failure possibilities. As a drawback we need to check for CVQ