Re: [PATCH v3 5/5] vfio-user: Fix config space access byte order

2023-09-15 Thread Mattias Nissler
On Thu, Sep 14, 2023 at 10:32 PM Stefan Hajnoczi wrote: > > On Thu, Sep 07, 2023 at 06:04:10AM -0700, Mattias Nissler wrote: > > PCI config space is little-endian, so on a big-endian host we need to > > perform byte swaps for values as they are passed to and received from > > the generic PCI confi

Re: [PATCH v3 5/5] vfio-user: Fix config space access byte order

2023-09-14 Thread Philippe Mathieu-Daudé
On 7/9/23 15:04, Mattias Nissler wrote: PCI config space is little-endian, so on a big-endian host we need to perform byte swaps for values as they are passed to and received from the generic PCI config space access machinery. Signed-off-by: Mattias Nissler --- hw/remote/vfio-user-obj.c | 4 +

Re: [PATCH v3 5/5] vfio-user: Fix config space access byte order

2023-09-14 Thread Stefan Hajnoczi
On Thu, Sep 07, 2023 at 06:04:10AM -0700, Mattias Nissler wrote: > PCI config space is little-endian, so on a big-endian host we need to > perform byte swaps for values as they are passed to and received from > the generic PCI config space access machinery. > > Signed-off-by: Mattias Nissler > --

Re: [PATCH v3 5/5] vfio-user: Fix config space access byte order

2023-09-14 Thread Stefan Hajnoczi
On Thu, Sep 07, 2023 at 06:04:10AM -0700, Mattias Nissler wrote: > PCI config space is little-endian, so on a big-endian host we need to > perform byte swaps for values as they are passed to and received from > the generic PCI config space access machinery. Byteswapping only works when registers a

[PATCH v3 5/5] vfio-user: Fix config space access byte order

2023-09-07 Thread Mattias Nissler
PCI config space is little-endian, so on a big-endian host we need to perform byte swaps for values as they are passed to and received from the generic PCI config space access machinery. Signed-off-by: Mattias Nissler --- hw/remote/vfio-user-obj.c | 4 ++-- 1 file changed, 2 insertions(+), 2 del