Re: [PATCH v3 50/66] hw/core/cpu: Move cpu properties to cpu-sysemu.c

2021-08-19 Thread Eduardo Habkost
On Thu, Aug 19, 2021 at 04:26:10PM +0100, Peter Maydell wrote: > On Wed, 18 Aug 2021 at 21:09, Richard Henderson > wrote: > > > > The comment in cpu-common.c is absolutely correct, we can't > > rely on the ifdef in a file built once. This was only "working" > > because we used ifndef. > > > > Sig

Re: [PATCH v3 50/66] hw/core/cpu: Move cpu properties to cpu-sysemu.c

2021-08-19 Thread Peter Maydell
On Wed, 18 Aug 2021 at 21:09, Richard Henderson wrote: > > The comment in cpu-common.c is absolutely correct, we can't > rely on the ifdef in a file built once. This was only "working" > because we used ifndef. > > Signed-off-by: Richard Henderson Fixes: 1b36e4f5a5de585 which moved the propert

[PATCH v3 50/66] hw/core/cpu: Move cpu properties to cpu-sysemu.c

2021-08-18 Thread Richard Henderson
The comment in cpu-common.c is absolutely correct, we can't rely on the ifdef in a file built once. This was only "working" because we used ifndef. Signed-off-by: Richard Henderson --- hw/core/cpu-common.h | 17 + hw/core/cpu-common.c | 18 ++ hw/core/cpu-sysemu.