Re: [PATCH v3 9/9] bsd-user/mmap.c: assert that target_mprotect cannot fail

2021-10-14 Thread Kyle Evans
On Fri, Oct 8, 2021 at 4:31 PM Warner Losh wrote: > > Similar to the equivalent linux-user change 86abac06c14. All error > conditions that target_mprotect checks are also checked by target_mmap. > EACCESS cannot happen because we are just removing PROT_WRITE. ENOMEM > should not happen because

[PATCH v3 9/9] bsd-user/mmap.c: assert that target_mprotect cannot fail

2021-10-08 Thread Warner Losh
Similar to the equivalent linux-user change 86abac06c14. All error conditions that target_mprotect checks are also checked by target_mmap. EACCESS cannot happen because we are just removing PROT_WRITE. ENOMEM should not happen because we are modifying a whole VMA (and we have bigger problems