Re: [PATCH v4] hostmem-file: add offset option

2023-04-04 Thread David Hildenbrand
Reviewed-by: Stefan Hajnoczi The change itself looks good to me, but I do think some other QEMU code that ends up working on the RAMBlock is not prepared yet. Most probably, because we never ended up using fd with an offset as guest RAM. We don't seem to be remembering that offset in the

Re: [PATCH v4] hostmem-file: add offset option

2023-04-03 Thread Alexander Graf
On 03.04.23 09:13, David Hildenbrand wrote: On 01.04.23 19:47, Stefan Hajnoczi wrote: On Sat, Apr 01, 2023 at 12:42:57PM +, Alexander Graf wrote: Add an option for hostmem-file to start the memory object at an offset into the target file. This is useful if multiple memory objects reside

Re: [PATCH v4] hostmem-file: add offset option

2023-04-03 Thread David Hildenbrand
On 03.04.23 17:49, Peter Xu wrote: On Mon, Apr 03, 2023 at 09:13:29AM +0200, David Hildenbrand wrote: On 01.04.23 19:47, Stefan Hajnoczi wrote: On Sat, Apr 01, 2023 at 12:42:57PM +, Alexander Graf wrote: Add an option for hostmem-file to start the memory object at an offset into the

Re: [PATCH v4] hostmem-file: add offset option

2023-04-03 Thread Peter Xu
On Mon, Apr 03, 2023 at 09:13:29AM +0200, David Hildenbrand wrote: > On 01.04.23 19:47, Stefan Hajnoczi wrote: > > On Sat, Apr 01, 2023 at 12:42:57PM +, Alexander Graf wrote: > > > Add an option for hostmem-file to start the memory object at an offset > > > into the target file. This is useful

Re: [PATCH v4] hostmem-file: add offset option

2023-04-03 Thread David Hildenbrand
On 01.04.23 19:47, Stefan Hajnoczi wrote: On Sat, Apr 01, 2023 at 12:42:57PM +, Alexander Graf wrote: Add an option for hostmem-file to start the memory object at an offset into the target file. This is useful if multiple memory objects reside inside the same target file, such as a device

Re: [PATCH v4] hostmem-file: add offset option

2023-04-01 Thread Stefan Hajnoczi
On Sat, Apr 01, 2023 at 12:42:57PM +, Alexander Graf wrote: > Add an option for hostmem-file to start the memory object at an offset > into the target file. This is useful if multiple memory objects reside > inside the same target file, such as a device node. > > In particular, it's useful to

[PATCH v4] hostmem-file: add offset option

2023-04-01 Thread Alexander Graf
Add an option for hostmem-file to start the memory object at an offset into the target file. This is useful if multiple memory objects reside inside the same target file, such as a device node. In particular, it's useful to map guest memory directly into /dev/mem for experimentation.