On Mon, 30 Mar 2020 at 06:54, Daniel Brodsky wrote:
> Using `#pragma clang diagnostic ignored
> "-Wtautological-type-limit-compare"` suppresses the errors (on Clang
> 9). I could go and drop that in for the problem areas? There's only a
> few so it wouldn't be a major change. I'm thinking of
On Sat, Mar 28, 2020 at 9:12 AM Richard Henderson
wrote:
>
> On 3/27/20 11:38 PM, Daniel Brodsky wrote:
> > On Thu, Mar 26, 2020 at 11:01 AM Richard Henderson
> > wrote:
> >>
> >> My preference is to add -Wno-tautological-type-limit-compare in
> >> configure, so we don't have to work around this
On 3/27/20 11:38 PM, Daniel Brodsky wrote:
> On Thu, Mar 26, 2020 at 11:01 AM Richard Henderson
> wrote:
>>
>> My preference is to add -Wno-tautological-type-limit-compare in
>> configure, so we don't have to work around this same issue elsewhere
>> in the code base.
>>
>> r~
>
> What do you
On Thu, Mar 26, 2020 at 11:01 AM Richard Henderson
wrote:
>
> My preference is to add -Wno-tautological-type-limit-compare in
> configure, so we don't have to work around this same issue elsewhere
> in the code base.
>
> r~
What do you think would be the best way to add this? I could change
all
On Wed, 25 Mar 2020 at 04:35, Daniel Brodsky wrote:
> > There may be ways to rewrite that expression to avoid triggering the
> > warning on a 32-bit platform. Untested, but does this help:
> >
> > if (sizeof(mask) > 4 && mask <= 0xu) {
> >
> > --
> > Eric Blake, Principal Software
>
> There may be ways to rewrite that expression to avoid triggering the
> warning on a 32-bit platform. Untested, but does this help:
>
> if (sizeof(mask) > 4 && mask <= 0xu) {
>
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc. +1-919-301-3226
> Virtualization:
You can test locally by building with clang (llvm) instead of gcc:
./configure --cc=clang
Using --cc=clang is causing the following error in several different places:
qemu/target/ppc/translate.c:1894:18: error: result of comparison
'target_ulong' (aka 'unsigned int') <= 4294967295
is
On 3/23/20 2:46 PM, Daniel Brodsky wrote:
> On Mon, Mar 23, 2020 at 6:25 AM Stefan Hajnoczi wrote:
>>
>> On Fri, Mar 20, 2020 at 06:43:23AM -0700, no-re...@patchew.org wrote:
>>> /tmp/qemu-test/src/util/thread-pool.c:213:5: error: unused variable
>>> 'qemu_lockable_auto1'
On Mon, Mar 23, 2020 at 6:25 AM Stefan Hajnoczi wrote:
>
> On Fri, Mar 20, 2020 at 06:43:23AM -0700, no-re...@patchew.org wrote:
> > /tmp/qemu-test/src/util/thread-pool.c:213:5: error: unused variable
> > 'qemu_lockable_auto1' [-Werror,-Wunused-variable]
> > QEMU_LOCK_GUARD(>lock);
> > ^
On Fri, Mar 20, 2020 at 06:43:23AM -0700, no-re...@patchew.org wrote:
> /tmp/qemu-test/src/util/thread-pool.c:213:5: error: unused variable
> 'qemu_lockable_auto1' [-Werror,-Wunused-variable]
> QEMU_LOCK_GUARD(>lock);
> ^
> /tmp/qemu-test/src/include/qemu/lockable.h:173:29: note: expanded
Patchew URL:
https://patchew.org/QEMU/20200320123137.1937091-1-dnbrd...@gmail.com/
Hi,
This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
From: Daniel Brodsky
This patch set adds:
- a fix for lock guard macros so they can be used multiple times in
the same function
- replacement of locks with lock guards where appropriate
v3 -> v4:
- removed unneeded unlocks from areas where lock guards are now used
- dropped change to lock guard
12 matches
Mail list logo
