Re: [PATCH v4 02/11] monitor/hmp: uninline add_init_drive

2020-03-04 Thread Maxim Levitsky
On Tue, 2020-03-03 at 18:10 +0100, Kevin Wolf wrote: > Am 30.01.2020 um 13:34 hat Maxim Levitsky geschrieben: > > This is only used by hmp_drive_add. > > The code is just a bit shorter this way. > > > > No functional changes > > > > Signed-off-by: Maxim Levitsky > > Reviewed-by: Markus Armbruste

Re: [PATCH v4 02/11] monitor/hmp: uninline add_init_drive

2020-03-03 Thread Kevin Wolf
Am 30.01.2020 um 13:34 hat Maxim Levitsky geschrieben: > This is only used by hmp_drive_add. > The code is just a bit shorter this way. > > No functional changes > > Signed-off-by: Maxim Levitsky > Reviewed-by: Markus Armbruster Shouldn't the subject say "inline" rather than "uninline"? Kevin

[PATCH v4 02/11] monitor/hmp: uninline add_init_drive

2020-01-30 Thread Maxim Levitsky
This is only used by hmp_drive_add. The code is just a bit shorter this way. No functional changes Signed-off-by: Maxim Levitsky Reviewed-by: Markus Armbruster --- device-hotplug.c | 31 --- 1 file changed, 12 insertions(+), 19 deletions(-) diff --git a/device-hotp