Re: [PATCH v4 03/11] target/mips: Create report_fault for semihosting

2022-06-11 Thread Richard Henderson
On 6/10/22 08:05, Philippe Mathieu-Daudé wrote: +static void report_fault(CPUMIPSState *env) +{ +    int op = env->active_tc.gpr[25]; +    error_report("Fault during UHI operation %d", op); +    abort(); This is a guest error, no need to debug QEMU internals... Can we simply exit(1) instead?

Re: [PATCH v4 03/11] target/mips: Create report_fault for semihosting

2022-06-10 Thread Philippe Mathieu-Daudé via
Hi Richard, On 8/6/22 07:19, Richard Henderson wrote: The UHI specification does not have an EFAULT value, and further specifies that "undefined UHI operations should not return control to the target". So, log the error and abort. Signed-off-by: Richard Henderson --- target/mips/tcg/sysemu/

[PATCH v4 03/11] target/mips: Create report_fault for semihosting

2022-06-07 Thread Richard Henderson
The UHI specification does not have an EFAULT value, and further specifies that "undefined UHI operations should not return control to the target". So, log the error and abort. Signed-off-by: Richard Henderson --- target/mips/tcg/sysemu/mips-semi.c | 33 ++ 1 file ch