Re: [PATCH v4 04/16] hw/i386: Introduce init_topo_info to initialize X86CPUTopoInfo

2020-02-24 Thread Babu Moger
On 2/24/20 2:18 AM, Igor Mammedov wrote: > On Fri, 21 Feb 2020 11:51:15 -0600 > Babu Moger wrote: > >> On 2/21/20 11:05 AM, Igor Mammedov wrote: >>> On Thu, 13 Feb 2020 12:16:51 -0600 >>> Babu Moger wrote: >>> Initialize all the parameters in one function init_topo_info. >>> >>> is

Re: [PATCH v4 04/16] hw/i386: Introduce init_topo_info to initialize X86CPUTopoInfo

2020-02-24 Thread Igor Mammedov
On Fri, 21 Feb 2020 11:51:15 -0600 Babu Moger wrote: > On 2/21/20 11:05 AM, Igor Mammedov wrote: > > On Thu, 13 Feb 2020 12:16:51 -0600 > > Babu Moger wrote: > > > >> Initialize all the parameters in one function init_topo_info. > > > > is it possible to squash it in 2/16 > > > Sure.

Re: [PATCH v4 04/16] hw/i386: Introduce init_topo_info to initialize X86CPUTopoInfo

2020-02-21 Thread Babu Moger
On 2/21/20 11:05 AM, Igor Mammedov wrote: > On Thu, 13 Feb 2020 12:16:51 -0600 > Babu Moger wrote: > >> Initialize all the parameters in one function init_topo_info. > > is it possible to squash it in 2/16 > Sure. We can do that. > >> >> Move the data structure X86CPUTopoIDs and

Re: [PATCH v4 04/16] hw/i386: Introduce init_topo_info to initialize X86CPUTopoInfo

2020-02-21 Thread Igor Mammedov
On Thu, 13 Feb 2020 12:16:51 -0600 Babu Moger wrote: > Initialize all the parameters in one function init_topo_info. is it possible to squash it in 2/16 > > Move the data structure X86CPUTopoIDs and X86CPUTopoInfo into > x86.h. A reason why it's moved should be here. > > Signed-off-by:

[PATCH v4 04/16] hw/i386: Introduce init_topo_info to initialize X86CPUTopoInfo

2020-02-13 Thread Babu Moger
Initialize all the parameters in one function init_topo_info. Move the data structure X86CPUTopoIDs and X86CPUTopoInfo into x86.h. Signed-off-by: Babu Moger Reviewed-by: Eduardo Habkost --- hw/i386/pc.c |4 +--- hw/i386/x86.c | 14 +++---