Re: [PATCH v4 05/12] hw/arm: Add NPCM730 and NPCM750 SoC models

2020-07-09 Thread Havard Skinnemoen
On Wed, Jul 8, 2020 at 10:34 PM Philippe Mathieu-Daudé wrote: > > On 7/9/20 2:06 AM, Havard Skinnemoen wrote: > > On Wed, Jul 8, 2020 at 11:13 AM Havard Skinnemoen > > wrote: > >> On Wed, Jul 8, 2020 at 10:31 AM Philippe Mathieu-Daudé > >> wrote: > >>> On 7/7/20 8:47 PM, Havard Skinnemoen wrote

Re: [PATCH v4 05/12] hw/arm: Add NPCM730 and NPCM750 SoC models

2020-07-08 Thread Philippe Mathieu-Daudé
On 7/9/20 2:06 AM, Havard Skinnemoen wrote: > On Wed, Jul 8, 2020 at 11:13 AM Havard Skinnemoen > wrote: >> On Wed, Jul 8, 2020 at 10:31 AM Philippe Mathieu-Daudé >> wrote: >>> On 7/7/20 8:47 PM, Havard Skinnemoen wrote: +typedef struct NPCM7xxClass { +DeviceClass parent; >

Re: [PATCH v4 05/12] hw/arm: Add NPCM730 and NPCM750 SoC models

2020-07-08 Thread Philippe Mathieu-Daudé
On 7/9/20 2:23 AM, Havard Skinnemoen wrote: > On Wed, Jul 8, 2020 at 10:56 AM Philippe Mathieu-Daudé > wrote: >> >> On 7/8/20 7:31 PM, Philippe Mathieu-Daudé wrote: >>> Hi Havard, >>> >>> On 7/7/20 8:47 PM, Havard Skinnemoen wrote: The Nuvoton NPCM7xx SoC family are used to implement Baseboa

Re: [PATCH v4 05/12] hw/arm: Add NPCM730 and NPCM750 SoC models

2020-07-08 Thread Havard Skinnemoen
On Wed, Jul 8, 2020 at 10:56 AM Philippe Mathieu-Daudé wrote: > > On 7/8/20 7:31 PM, Philippe Mathieu-Daudé wrote: > > Hi Havard, > > > > On 7/7/20 8:47 PM, Havard Skinnemoen wrote: > >> The Nuvoton NPCM7xx SoC family are used to implement Baseboard > >> Management Controllers in servers. While th

Re: [PATCH v4 05/12] hw/arm: Add NPCM730 and NPCM750 SoC models

2020-07-08 Thread Havard Skinnemoen
On Wed, Jul 8, 2020 at 11:13 AM Havard Skinnemoen wrote: > On Wed, Jul 8, 2020 at 10:31 AM Philippe Mathieu-Daudé > wrote: > > On 7/7/20 8:47 PM, Havard Skinnemoen wrote: > > > +typedef struct NPCM7xxClass { > > > +DeviceClass parent; > > > > Similar comment that elsewhere on this se

Re: [PATCH v4 05/12] hw/arm: Add NPCM730 and NPCM750 SoC models

2020-07-08 Thread Havard Skinnemoen
On Wed, Jul 8, 2020 at 11:13 AM Havard Skinnemoen wrote: > > On Wed, Jul 8, 2020 at 10:31 AM Philippe Mathieu-Daudé > wrote: > > > > On 7/7/20 8:47 PM, Havard Skinnemoen wrote: > > > +/* System Global Control Registers (GCR) */ > > > +object_property_set_int(OBJECT(&s->gcr), nc->disabled

Re: [PATCH v4 05/12] hw/arm: Add NPCM730 and NPCM750 SoC models

2020-07-08 Thread Havard Skinnemoen
On Wed, Jul 8, 2020 at 10:31 AM Philippe Mathieu-Daudé wrote: > > Hi Havard, > > On 7/7/20 8:47 PM, Havard Skinnemoen wrote: > > The Nuvoton NPCM7xx SoC family are used to implement Baseboard > > Management Controllers in servers. While the family includes four SoCs, > > this patch implements limi

Re: [PATCH v4 05/12] hw/arm: Add NPCM730 and NPCM750 SoC models

2020-07-08 Thread Philippe Mathieu-Daudé
On 7/8/20 7:31 PM, Philippe Mathieu-Daudé wrote: > Hi Havard, > > On 7/7/20 8:47 PM, Havard Skinnemoen wrote: >> The Nuvoton NPCM7xx SoC family are used to implement Baseboard >> Management Controllers in servers. While the family includes four SoCs, >> this patch implements limited support for tw

Re: [PATCH v4 05/12] hw/arm: Add NPCM730 and NPCM750 SoC models

2020-07-08 Thread Philippe Mathieu-Daudé
Hi Havard, On 7/7/20 8:47 PM, Havard Skinnemoen wrote: > The Nuvoton NPCM7xx SoC family are used to implement Baseboard > Management Controllers in servers. While the family includes four SoCs, > this patch implements limited support for two of them: NPCM730 (targeted > for Data Center application

[PATCH v4 05/12] hw/arm: Add NPCM730 and NPCM750 SoC models

2020-07-07 Thread Havard Skinnemoen
The Nuvoton NPCM7xx SoC family are used to implement Baseboard Management Controllers in servers. While the family includes four SoCs, this patch implements limited support for two of them: NPCM730 (targeted for Data Center applications) and NPCM750 (targeted for Enterprise applications). This pat