Re: [PATCH v4 05/25] s390/stattrib: Add Error** argument to set_migrationmode() handler

2024-03-08 Thread Thomas Huth
On 06/03/2024 14.34, Cédric Le Goater wrote: This will prepare ground for future changes adding an Error** argument to the save_setup() handler. We need to make sure that on failure, set_migrationmode() always sets a new error. See the Rules section in qapi/error.h. Cc: Halil Pasic Cc: Christia

Re: [PATCH v4 05/25] s390/stattrib: Add Error** argument to set_migrationmode() handler

2024-03-08 Thread Peter Xu
On Wed, Mar 06, 2024 at 02:34:20PM +0100, Cédric Le Goater wrote: > This will prepare ground for future changes adding an Error** argument > to the save_setup() handler. We need to make sure that on failure, > set_migrationmode() always sets a new error. See the Rules section in > qapi/error.h. >

Re: [PATCH v4 05/25] s390/stattrib: Add Error** argument to set_migrationmode() handler

2024-03-07 Thread Fabiano Rosas
Cédric Le Goater writes: > This will prepare ground for future changes adding an Error** argument > to the save_setup() handler. We need to make sure that on failure, > set_migrationmode() always sets a new error. See the Rules section in > qapi/error.h. > > Cc: Halil Pasic > Cc: Christian Bornt

[PATCH v4 05/25] s390/stattrib: Add Error** argument to set_migrationmode() handler

2024-03-06 Thread Cédric Le Goater
This will prepare ground for future changes adding an Error** argument to the save_setup() handler. We need to make sure that on failure, set_migrationmode() always sets a new error. See the Rules section in qapi/error.h. Cc: Halil Pasic Cc: Christian Borntraeger Cc: Thomas Huth Signed-off-by: