Re: [PATCH v4 09/19] qapi/expr.py: Check type of 'data' member

2021-03-25 Thread John Snow
On 3/25/21 10:26 AM, Markus Armbruster wrote: Suggest qapi/expr.py: Check type of union and alternate 'data' member John Snow writes: We don't actually check, so the user can get some unpleasant stacktraces. Let's point to the new tests here. Well, it'll get merged with the last

Re: [PATCH v4 09/19] qapi/expr.py: Check type of 'data' member

2021-03-25 Thread Markus Armbruster
Suggest qapi/expr.py: Check type of union and alternate 'data' member John Snow writes: > We don't actually check, so the user can get some unpleasant stacktraces. Let's point to the new tests here. > Formalize it. Huh? > Signed-off-by: John Snow > --- > scripts/qapi/expr.py

[PATCH v4 09/19] qapi/expr.py: Check type of 'data' member

2021-03-25 Thread John Snow
We don't actually check, so the user can get some unpleasant stacktraces. Formalize it. Signed-off-by: John Snow --- scripts/qapi/expr.py | 7 +++ tests/qapi-schema/alternate-invalid-data-type.err | 2 ++ tests/qapi-schema/union-invalid-data-type.err | 2 ++