Re: [PATCH v4 1/3] qmp.py: change event_wait to use a dict

2020-06-16 Thread John Snow
On 6/16/20 5:41 PM, Eric Blake wrote: > On 5/14/20 2:31 PM, John Snow wrote: > Nah, it's fine. I'll clean it up. This is pretty close to an RFC series anyway, so I didn't really polish it. (Or, I will try to clean it up. I probably won't work on it again in the

Re: [PATCH v4 1/3] qmp.py: change event_wait to use a dict

2020-06-16 Thread Eric Blake
On 5/14/20 2:31 PM, John Snow wrote: Nah, it's fine. I'll clean it up. This is pretty close to an RFC series anyway, so I didn't really polish it. (Or, I will try to clean it up. I probably won't work on it again in the near term. I think I just wanted to see if this seemed useful in general

Re: [PATCH v4 1/3] qmp.py: change event_wait to use a dict

2020-05-14 Thread John Snow
On 5/14/20 11:59 AM, Kevin Wolf wrote: > Am 14.05.2020 um 17:07 hat John Snow geschrieben: >> >> >> On 5/14/20 10:47 AM, Kevin Wolf wrote: >>> Am 14.05.2020 um 04:25 hat John Snow geschrieben: It's easier to work with than a list of tuples, because we can check the keys for

Re: [PATCH v4 1/3] qmp.py: change event_wait to use a dict

2020-05-14 Thread Kevin Wolf
Am 14.05.2020 um 17:07 hat John Snow geschrieben: > > > On 5/14/20 10:47 AM, Kevin Wolf wrote: > > Am 14.05.2020 um 04:25 hat John Snow geschrieben: > >> It's easier to work with than a list of tuples, because we can check the > >> keys for membership. > >> > >> Signed-off-by: John Snow > >>

Re: [PATCH v4 1/3] qmp.py: change event_wait to use a dict

2020-05-14 Thread John Snow
On 5/14/20 10:47 AM, Kevin Wolf wrote: > Am 14.05.2020 um 04:25 hat John Snow geschrieben: >> It's easier to work with than a list of tuples, because we can check the >> keys for membership. >> >> Signed-off-by: John Snow >> --- >> python/qemu/machine.py| 10 +- >>

Re: [PATCH v4 1/3] qmp.py: change event_wait to use a dict

2020-05-14 Thread Kevin Wolf
Am 14.05.2020 um 04:25 hat John Snow geschrieben: > It's easier to work with than a list of tuples, because we can check the > keys for membership. > > Signed-off-by: John Snow > --- > python/qemu/machine.py| 10 +- > tests/qemu-iotests/040| 12 ++-- >

[PATCH v4 1/3] qmp.py: change event_wait to use a dict

2020-05-13 Thread John Snow
It's easier to work with than a list of tuples, because we can check the keys for membership. Signed-off-by: John Snow --- python/qemu/machine.py| 10 +- tests/qemu-iotests/040| 12 ++-- tests/qemu-iotests/260| 5 +++-- tests/qemu-iotests/iotests.py | 16