Re: [PATCH v4 1/3] virtio-blk: store opt_io_size with correct size

2020-05-20 Thread Roman Kagan
On Wed, May 20, 2020 at 06:44:44AM -0400, Michael S. Tsirkin wrote: > On Wed, May 20, 2020 at 11:06:55AM +0300, Roman Kagan wrote: > > The width of opt_io_size in virtio_blk_topology is 32bit. > > > > Use the appropriate accessor to store it. > > > > Signed-off-by: Roman Kagan > > > Thanks

Re: [PATCH v4 1/3] virtio-blk: store opt_io_size with correct size

2020-05-20 Thread Roman Kagan
On Wed, May 20, 2020 at 05:36:58PM +0200, Kevin Wolf wrote: > Am 20.05.2020 um 10:06 hat Roman Kagan geschrieben: > > The width of opt_io_size in virtio_blk_topology is 32bit. > > I think you mean virtio_blk_config? I consulted virtio-v1.1 spec where the topology-related fields are grouped in

Re: [PATCH v4 1/3] virtio-blk: store opt_io_size with correct size

2020-05-20 Thread Kevin Wolf
Am 20.05.2020 um 10:06 hat Roman Kagan geschrieben: > The width of opt_io_size in virtio_blk_topology is 32bit. I think you mean virtio_blk_config? > Use the appropriate accessor to store it. > > Signed-off-by: Roman Kagan Reviewed-by: Kevin Wolf

Re: [PATCH v4 1/3] virtio-blk: store opt_io_size with correct size

2020-05-20 Thread Michael S. Tsirkin
On Wed, May 20, 2020 at 11:06:55AM +0300, Roman Kagan wrote: > The width of opt_io_size in virtio_blk_topology is 32bit. > > Use the appropriate accessor to store it. > > Signed-off-by: Roman Kagan Thanks for the patch! Could you add a bit of analysis - when does this cause bugs? I'm guessing

Re: [PATCH v4 1/3] virtio-blk: store opt_io_size with correct size

2020-05-20 Thread Philippe Mathieu-Daudé
On 5/20/20 10:06 AM, Roman Kagan wrote: The width of opt_io_size in virtio_blk_topology is 32bit. Use the appropriate accessor to store it. Signed-off-by: Roman Kagan --- v4: new patch hw/block/virtio-blk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v4 1/3] virtio-blk: store opt_io_size with correct size

2020-05-20 Thread Roman Kagan
The width of opt_io_size in virtio_blk_topology is 32bit. Use the appropriate accessor to store it. Signed-off-by: Roman Kagan --- v4: new patch hw/block/virtio-blk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index