Re: [PATCH v4 1/4] s390x/css: Introduce an ESW struct

2021-07-06 Thread Philippe Mathieu-Daudé
Hi Eric, On 6/18/21 1:25 AM, Eric Farman wrote: > The Interrupt Response Block is comprised of several other > structures concatenated together, but only the 12-byte > Subchannel-Status Word (SCSW) is defined as a proper struct. > Everything else is a simple array of 32-bit words. > > Let's defin

Re: [PATCH v4 1/4] s390x/css: Introduce an ESW struct

2021-06-18 Thread Cornelia Huck
On Fri, Jun 18 2021, Eric Farman wrote: > On Fri, 2021-06-18 at 14:46 +0200, Cornelia Huck wrote: >> On Fri, Jun 18 2021, Cornelia Huck wrote: >> >> > On Fri, Jun 18 2021, Eric Farman wrote: >> > > +/* format-0 extended-status word */ >> > > +typedef struct ESW { >> > > + uint32_t word0; >>

Re: [PATCH v4 1/4] s390x/css: Introduce an ESW struct

2021-06-18 Thread Eric Farman
On Fri, 2021-06-18 at 11:38 +0200, Cornelia Huck wrote: > On Fri, Jun 18 2021, Eric Farman wrote: > > > The Interrupt Response Block is comprised of several other > > structures concatenated together, but only the 12-byte > > Subchannel-Status Word (SCSW) is defined as a proper struct. > > Everyt

Re: [PATCH v4 1/4] s390x/css: Introduce an ESW struct

2021-06-18 Thread Eric Farman
On Fri, 2021-06-18 at 14:46 +0200, Cornelia Huck wrote: > On Fri, Jun 18 2021, Cornelia Huck wrote: > > > On Fri, Jun 18 2021, Eric Farman wrote: > > > > > The Interrupt Response Block is comprised of several other > > > structures concatenated together, but only the 12-byte > > > Subchannel-St

Re: [PATCH v4 1/4] s390x/css: Introduce an ESW struct

2021-06-18 Thread Cornelia Huck
On Fri, Jun 18 2021, Cornelia Huck wrote: > On Fri, Jun 18 2021, Eric Farman wrote: > >> The Interrupt Response Block is comprised of several other >> structures concatenated together, but only the 12-byte >> Subchannel-Status Word (SCSW) is defined as a proper struct. >> Everything else is a si

Re: [PATCH v4 1/4] s390x/css: Introduce an ESW struct

2021-06-18 Thread Cornelia Huck
On Fri, Jun 18 2021, Eric Farman wrote: > The Interrupt Response Block is comprised of several other > structures concatenated together, but only the 12-byte > Subchannel-Status Word (SCSW) is defined as a proper struct. > Everything else is a simple array of 32-bit words. > > Let's define a prop

Re: [PATCH v4 1/4] s390x/css: Introduce an ESW struct

2021-06-18 Thread Cornelia Huck
On Fri, Jun 18 2021, Eric Farman wrote: > The Interrupt Response Block is comprised of several other > structures concatenated together, but only the 12-byte > Subchannel-Status Word (SCSW) is defined as a proper struct. > Everything else is a simple array of 32-bit words. > > Let's define a prop

[PATCH v4 1/4] s390x/css: Introduce an ESW struct

2021-06-17 Thread Eric Farman
The Interrupt Response Block is comprised of several other structures concatenated together, but only the 12-byte Subchannel-Status Word (SCSW) is defined as a proper struct. Everything else is a simple array of 32-bit words. Let's define a proper struct for the 20-byte Extended-Status Word (ESW)