Re: [PATCH v4 10/19] migration: Postcopy preemption enablement

2022-05-13 Thread Peter Xu
On Sat, May 14, 2022 at 12:23:44AM +0530, manish.mishra wrote: > > On 12/05/22 9:52 pm, Peter Xu wrote: > > Hi, Manish, > > > > On Wed, May 11, 2022 at 09:24:28PM +0530, manish.mishra wrote: > > > > @@ -1962,9 +2038,17 @@ static bool get_queued_page(RAMState *rs, > > > > PageSearchStatus *pss) >

Re: [PATCH v4 10/19] migration: Postcopy preemption enablement

2022-05-13 Thread manish.mishra
On 12/05/22 9:52 pm, Peter Xu wrote: Hi, Manish, On Wed, May 11, 2022 at 09:24:28PM +0530, manish.mishra wrote: @@ -1962,9 +2038,17 @@ static bool get_queued_page(RAMState *rs, PageSearchStatus *pss) RAMBlock *block; ram_addr_t offset; +again: block = unqueue_page(rs, &

Re: [PATCH v4 10/19] migration: Postcopy preemption enablement

2022-05-12 Thread Peter Xu
Hi, Manish, On Wed, May 11, 2022 at 09:24:28PM +0530, manish.mishra wrote: > > @@ -1962,9 +2038,17 @@ static bool get_queued_page(RAMState *rs, > > PageSearchStatus *pss) > > RAMBlock *block; > > ram_addr_t offset; > > +again: > > block = unqueue_page(rs, &offset); > > -if

Re: [PATCH v4 10/19] migration: Postcopy preemption enablement

2022-05-11 Thread manish.mishra
On 31/03/22 8:38 pm, Peter Xu wrote: LGTM This patch enables postcopy-preempt feature. It contains two major changes to the migration logic: (1) Postcopy requests are now sent via a different socket from precopy background migration stream, so as to be isolated from very high page r

Re: [PATCH v4 10/19] migration: Postcopy preemption enablement

2022-04-20 Thread Peter Xu
On Wed, Apr 20, 2022 at 12:05:24PM +0100, Daniel P. Berrangé wrote: > On Thu, Mar 31, 2022 at 11:08:48AM -0400, Peter Xu wrote: > > This patch enables postcopy-preempt feature. > > > > It contains two major changes to the migration logic: > > > > (1) Postcopy requests are now sent via a different

Re: [PATCH v4 10/19] migration: Postcopy preemption enablement

2022-04-20 Thread Daniel P . Berrangé
On Thu, Mar 31, 2022 at 11:08:48AM -0400, Peter Xu wrote: > This patch enables postcopy-preempt feature. > > It contains two major changes to the migration logic: > > (1) Postcopy requests are now sent via a different socket from precopy > background migration stream, so as to be isolated fro

[PATCH v4 10/19] migration: Postcopy preemption enablement

2022-03-31 Thread Peter Xu
This patch enables postcopy-preempt feature. It contains two major changes to the migration logic: (1) Postcopy requests are now sent via a different socket from precopy background migration stream, so as to be isolated from very high page request delays. (2) For huge page enabled hosts: