Re: [PATCH v4 11/12] virtiofsd: Optionally fill lo_inode.fhandle

2021-10-20 Thread Vivek Goyal
On Wed, Oct 20, 2021 at 12:00:07PM +0200, Hanna Reitz wrote: [..] > > > @@ -1302,13 +1512,26 @@ static int lo_do_lookup(fuse_req_t req, > > > fuse_ino_t parent, const char *name, > > > goto out; > > > } > > > -newfd = openat(dir_path_fd.fd, name, O_PATH | O_NOFOLLOW); > > > -

Re: [PATCH v4 11/12] virtiofsd: Optionally fill lo_inode.fhandle

2021-10-20 Thread Hanna Reitz
On 19.10.21 20:57, Vivek Goyal wrote: On Thu, Sep 16, 2021 at 10:40:44AM +0200, Hanna Reitz wrote: When the inode_file_handles option is set, try to generate a file handle for new inodes instead of opening an O_PATH FD. Being able to open these again will require CAP_DAC_READ_SEARCH, so setting

Re: [PATCH v4 11/12] virtiofsd: Optionally fill lo_inode.fhandle

2021-10-19 Thread Vivek Goyal
On Thu, Sep 16, 2021 at 10:40:44AM +0200, Hanna Reitz wrote: > When the inode_file_handles option is set, try to generate a file handle > for new inodes instead of opening an O_PATH FD. > > Being able to open these again will require CAP_DAC_READ_SEARCH, so > setting this option will result in us

[PATCH v4 11/12] virtiofsd: Optionally fill lo_inode.fhandle

2021-09-16 Thread Hanna Reitz
When the inode_file_handles option is set, try to generate a file handle for new inodes instead of opening an O_PATH FD. Being able to open these again will require CAP_DAC_READ_SEARCH, so setting this option will result in us taking that capability. Generating a file handle returns the mount ID