Re: [PATCH v4 12/16] hw/i386: Use the apicid handlers from X86MachineState

2020-02-25 Thread Babu Moger
On 2/25/20 9:32 AM, Eduardo Habkost wrote: > On Mon, Feb 24, 2020 at 05:13:18PM -0600, Babu Moger wrote: >> >> >> On 2/24/20 4:31 PM, Eduardo Habkost wrote: >>> On Mon, Feb 24, 2020 at 11:58:09AM -0600, Babu Moger wrote: On 2/24/20 11:19 AM, Igor Mammedov wrote: > On Thu, 13

Re: [PATCH v4 12/16] hw/i386: Use the apicid handlers from X86MachineState

2020-02-25 Thread Eduardo Habkost
On Mon, Feb 24, 2020 at 05:13:18PM -0600, Babu Moger wrote: > > > On 2/24/20 4:31 PM, Eduardo Habkost wrote: > > On Mon, Feb 24, 2020 at 11:58:09AM -0600, Babu Moger wrote: > >> > >> > >> On 2/24/20 11:19 AM, Igor Mammedov wrote: > >>> On Thu, 13 Feb 2020 12:17:46 -0600 > >>> Babu Moger wrote:

Re: [PATCH v4 12/16] hw/i386: Use the apicid handlers from X86MachineState

2020-02-25 Thread Eduardo Habkost
On Tue, Feb 25, 2020 at 09:16:32AM +0100, Igor Mammedov wrote: > On Mon, 24 Feb 2020 17:31:49 -0500 > Eduardo Habkost wrote: > > > On Mon, Feb 24, 2020 at 11:58:09AM -0600, Babu Moger wrote: > > > > > > > > > On 2/24/20 11:19 AM, Igor Mammedov wrote: > > > > On Thu, 13 Feb 2020 12:17:46

Re: [PATCH v4 12/16] hw/i386: Use the apicid handlers from X86MachineState

2020-02-25 Thread Igor Mammedov
On Mon, 24 Feb 2020 17:31:49 -0500 Eduardo Habkost wrote: > On Mon, Feb 24, 2020 at 11:58:09AM -0600, Babu Moger wrote: > > > > > > On 2/24/20 11:19 AM, Igor Mammedov wrote: > > > On Thu, 13 Feb 2020 12:17:46 -0600 > > > Babu Moger wrote: > > > > > >> Check and Load the apicid handlers

Re: [PATCH v4 12/16] hw/i386: Use the apicid handlers from X86MachineState

2020-02-24 Thread Babu Moger
On 2/24/20 4:31 PM, Eduardo Habkost wrote: > On Mon, Feb 24, 2020 at 11:58:09AM -0600, Babu Moger wrote: >> >> >> On 2/24/20 11:19 AM, Igor Mammedov wrote: >>> On Thu, 13 Feb 2020 12:17:46 -0600 >>> Babu Moger wrote: >>> Check and Load the apicid handlers from X86CPUDefinition if

Re: [PATCH v4 12/16] hw/i386: Use the apicid handlers from X86MachineState

2020-02-24 Thread Eduardo Habkost
On Mon, Feb 24, 2020 at 11:58:09AM -0600, Babu Moger wrote: > > > On 2/24/20 11:19 AM, Igor Mammedov wrote: > > On Thu, 13 Feb 2020 12:17:46 -0600 > > Babu Moger wrote: > > > >> Check and Load the apicid handlers from X86CPUDefinition if available. > >> Update the calling convention for the

Re: [PATCH v4 12/16] hw/i386: Use the apicid handlers from X86MachineState

2020-02-24 Thread Babu Moger
On 2/24/20 11:19 AM, Igor Mammedov wrote: > On Thu, 13 Feb 2020 12:17:46 -0600 > Babu Moger wrote: > >> Check and Load the apicid handlers from X86CPUDefinition if available. >> Update the calling convention for the apicid handlers. > > Previous and this patch look too complicated for the

Re: [PATCH v4 12/16] hw/i386: Use the apicid handlers from X86MachineState

2020-02-24 Thread Igor Mammedov
On Thu, 13 Feb 2020 12:17:46 -0600 Babu Moger wrote: > Check and Load the apicid handlers from X86CPUDefinition if available. > Update the calling convention for the apicid handlers. Previous and this patch look too complicated for the task at the hand. In particular, cpu_x86_init_apicid_fns()

[PATCH v4 12/16] hw/i386: Use the apicid handlers from X86MachineState

2020-02-13 Thread Babu Moger
Check and Load the apicid handlers from X86CPUDefinition if available. Update the calling convention for the apicid handlers. Signed-off-by: Babu Moger --- hw/i386/pc.c |6 +++--- hw/i386/x86.c | 27 +++ 2 files changed, 26 insertions(+), 7 deletions(-) diff