Re: [PATCH v4 16/21] i386: track explicit 'hv-*' features enablement/disablement

2021-03-01 Thread Vitaly Kuznetsov
Igor Mammedov writes: > On Wed, 24 Feb 2021 18:00:43 +0100 > Vitaly Kuznetsov wrote: > >> Igor Mammedov writes: >> >> > On Tue, 23 Feb 2021 19:08:42 +0100 >> > Vitaly Kuznetsov wrote: >> > >> >> Igor Mammedov writes: >> >> >> >> > On Tue, 23 Feb 2021 16:46:50 +0100 >> >> > Vitaly Kuznet

Re: [PATCH v4 16/21] i386: track explicit 'hv-*' features enablement/disablement

2021-03-01 Thread Igor Mammedov
On Wed, 24 Feb 2021 18:00:43 +0100 Vitaly Kuznetsov wrote: > Igor Mammedov writes: > > > On Tue, 23 Feb 2021 19:08:42 +0100 > > Vitaly Kuznetsov wrote: > > > >> Igor Mammedov writes: > >> > >> > On Tue, 23 Feb 2021 16:46:50 +0100 > >> > Vitaly Kuznetsov wrote: > >> > > >> >> Igor Ma

Re: [PATCH v4 16/21] i386: track explicit 'hv-*' features enablement/disablement

2021-02-24 Thread Vitaly Kuznetsov
Igor Mammedov writes: > On Tue, 23 Feb 2021 19:08:42 +0100 > Vitaly Kuznetsov wrote: > >> Igor Mammedov writes: >> >> > On Tue, 23 Feb 2021 16:46:50 +0100 >> > Vitaly Kuznetsov wrote: >> > >> >> Igor Mammedov writes: >> >> >> >> > On Mon, 22 Feb 2021 11:20:34 +0100 >> >> > Vitaly Kuznet

Re: [PATCH v4 16/21] i386: track explicit 'hv-*' features enablement/disablement

2021-02-24 Thread Igor Mammedov
On Tue, 23 Feb 2021 19:08:42 +0100 Vitaly Kuznetsov wrote: > Igor Mammedov writes: > > > On Tue, 23 Feb 2021 16:46:50 +0100 > > Vitaly Kuznetsov wrote: > > > >> Igor Mammedov writes: > >> > >> > On Mon, 22 Feb 2021 11:20:34 +0100 > >> > Vitaly Kuznetsov wrote: > >> > > >> >> Vitaly

Re: [PATCH v4 16/21] i386: track explicit 'hv-*' features enablement/disablement

2021-02-23 Thread Vitaly Kuznetsov
Igor Mammedov writes: > On Tue, 23 Feb 2021 16:46:50 +0100 > Vitaly Kuznetsov wrote: > >> Igor Mammedov writes: >> >> > On Mon, 22 Feb 2021 11:20:34 +0100 >> > Vitaly Kuznetsov wrote: >> > >> >> Vitaly Kuznetsov writes: >> >> >> >> > Igor Mammedov writes: >> >> > >> >> >>> >> >> >

Re: [PATCH v4 16/21] i386: track explicit 'hv-*' features enablement/disablement

2021-02-23 Thread Igor Mammedov
On Tue, 23 Feb 2021 16:46:50 +0100 Vitaly Kuznetsov wrote: > Igor Mammedov writes: > > > On Mon, 22 Feb 2021 11:20:34 +0100 > > Vitaly Kuznetsov wrote: > > > >> Vitaly Kuznetsov writes: > >> > >> > Igor Mammedov writes: > >> > > >> >>> > >> >>> We need to distinguish because that w

Re: [PATCH v4 16/21] i386: track explicit 'hv-*' features enablement/disablement

2021-02-23 Thread Vitaly Kuznetsov
Igor Mammedov writes: > On Mon, 22 Feb 2021 11:20:34 +0100 > Vitaly Kuznetsov wrote: > >> Vitaly Kuznetsov writes: >> >> > Igor Mammedov writes: >> > >> >>> >> >>> We need to distinguish because that would be sane. >> >>> >> >>> Enlightened VMCS is an extension to VMX, it can't be used wi

Re: [PATCH v4 16/21] i386: track explicit 'hv-*' features enablement/disablement

2021-02-23 Thread Igor Mammedov
On Mon, 22 Feb 2021 11:20:34 +0100 Vitaly Kuznetsov wrote: > Vitaly Kuznetsov writes: > > > Igor Mammedov writes: > > > >>> > >>> We need to distinguish because that would be sane. > >>> > >>> Enlightened VMCS is an extension to VMX, it can't be used without > >>> it. Genuine Hyper-V doesn

Re: [PATCH v4 16/21] i386: track explicit 'hv-*' features enablement/disablement

2021-02-22 Thread Vitaly Kuznetsov
Vitaly Kuznetsov writes: > Igor Mammedov writes: > >>> >>> We need to distinguish because that would be sane. >>> >>> Enlightened VMCS is an extension to VMX, it can't be used without >>> it. Genuine Hyper-V doesn't have a knob for enabling and disabling it, >> ... >>> That bein said, if >>> g

Re: [PATCH v4 16/21] i386: track explicit 'hv-*' features enablement/disablement

2021-02-15 Thread Vitaly Kuznetsov
Igor Mammedov writes: > On Mon, 15 Feb 2021 09:56:19 +0100 > Vitaly Kuznetsov wrote: > >> Igor Mammedov writes: >> >> > On Fri, 12 Feb 2021 16:26:03 +0100 >> > Vitaly Kuznetsov wrote: >> > >> >> Vitaly Kuznetsov writes: >> >> >> >> > Igor Mammedov writes: >> >> > >> >> >> >> >> >>

Re: [PATCH v4 16/21] i386: track explicit 'hv-*' features enablement/disablement

2021-02-15 Thread Vitaly Kuznetsov
Igor Mammedov writes: >> >> We need to distinguish because that would be sane. >> >> Enlightened VMCS is an extension to VMX, it can't be used without >> it. Genuine Hyper-V doesn't have a knob for enabling and disabling it, > ... >> That bein said, if >> guest CPU lacks VMX it is counter-produ

Re: [PATCH v4 16/21] i386: track explicit 'hv-*' features enablement/disablement

2021-02-15 Thread Igor Mammedov
On Mon, 15 Feb 2021 16:55:02 +0100 Igor Mammedov wrote: > On Mon, 15 Feb 2021 09:56:19 +0100 > Vitaly Kuznetsov wrote: > > > Igor Mammedov writes: > > > > > On Fri, 12 Feb 2021 16:26:03 +0100 > > > Vitaly Kuznetsov wrote: > > > > > >> Vitaly Kuznetsov writes: > > >> > > >> > Igor

Re: [PATCH v4 16/21] i386: track explicit 'hv-*' features enablement/disablement

2021-02-15 Thread Igor Mammedov
On Mon, 15 Feb 2021 09:53:50 +0100 Vitaly Kuznetsov wrote: > Igor Mammedov writes: > > >> > > >> > Please try reusing scratch CPU approach, see > >> > kvm_arm_get_host_cpu_features() > >> > for an example. You will very likely end up with simpler series, > >> > compared to reinventing wheel.

Re: [PATCH v4 16/21] i386: track explicit 'hv-*' features enablement/disablement

2021-02-15 Thread Igor Mammedov
On Mon, 15 Feb 2021 09:56:19 +0100 Vitaly Kuznetsov wrote: > Igor Mammedov writes: > > > On Fri, 12 Feb 2021 16:26:03 +0100 > > Vitaly Kuznetsov wrote: > > > >> Vitaly Kuznetsov writes: > >> > >> > Igor Mammedov writes: > >> > > >> >> > >> >> Please try reusing scratch CPU approach,

Re: [PATCH v4 16/21] i386: track explicit 'hv-*' features enablement/disablement

2021-02-15 Thread Andrew Jones
On Mon, Feb 15, 2021 at 09:53:50AM +0100, Vitaly Kuznetsov wrote: > I have no clue why scratch vCPUs were implemented on ARM, however, I'd We don't have an ioctl like KVM_GET_SUPPORTED_CPUID, which operates on the KVM fd. Perhaps we should. Thanks, drew

Re: [PATCH v4 16/21] i386: track explicit 'hv-*' features enablement/disablement

2021-02-15 Thread Vitaly Kuznetsov
Igor Mammedov writes: > On Fri, 12 Feb 2021 16:26:03 +0100 > Vitaly Kuznetsov wrote: > >> Vitaly Kuznetsov writes: >> >> > Igor Mammedov writes: >> > >> >> >> >> Please try reusing scratch CPU approach, see >> >> kvm_arm_get_host_cpu_features() >> >> for an example. You will very likely e

Re: [PATCH v4 16/21] i386: track explicit 'hv-*' features enablement/disablement

2021-02-15 Thread Vitaly Kuznetsov
Igor Mammedov writes: >> > >> > Please try reusing scratch CPU approach, see >> > kvm_arm_get_host_cpu_features() >> > for an example. You will very likely end up with simpler series, >> > compared to reinventing wheel. >> >> Even if I do that (and I serioulsy doubt it's going to be easier t

Re: [PATCH v4 16/21] i386: track explicit 'hv-*' features enablement/disablement

2021-02-12 Thread Igor Mammedov
On Fri, 12 Feb 2021 16:26:03 +0100 Vitaly Kuznetsov wrote: > Vitaly Kuznetsov writes: > > > Igor Mammedov writes: > > > >> > >> Please try reusing scratch CPU approach, see > >> kvm_arm_get_host_cpu_features() > >> for an example. You will very likely end up with simpler series, > >> compa

Re: [PATCH v4 16/21] i386: track explicit 'hv-*' features enablement/disablement

2021-02-12 Thread Igor Mammedov
On Fri, 12 Feb 2021 16:19:24 +0100 Vitaly Kuznetsov wrote: > Igor Mammedov writes: > > > On Fri, 12 Feb 2021 09:45:52 +0100 > > Vitaly Kuznetsov wrote: > > > >> Igor Mammedov writes: > >> > >> > On Wed, 10 Feb 2021 17:40:28 +0100 > >> > Vitaly Kuznetsov wrote: > >> > > >> >> Sometim

Re: [PATCH v4 16/21] i386: track explicit 'hv-*' features enablement/disablement

2021-02-12 Thread Vitaly Kuznetsov
Vitaly Kuznetsov writes: > Igor Mammedov writes: > >> >> Please try reusing scratch CPU approach, see >> kvm_arm_get_host_cpu_features() >> for an example. You will very likely end up with simpler series, >> compared to reinventing wheel. > > Even if I do that (and I serioulsy doubt it's going

Re: [PATCH v4 16/21] i386: track explicit 'hv-*' features enablement/disablement

2021-02-12 Thread Vitaly Kuznetsov
Igor Mammedov writes: > On Fri, 12 Feb 2021 09:45:52 +0100 > Vitaly Kuznetsov wrote: > >> Igor Mammedov writes: >> >> > On Wed, 10 Feb 2021 17:40:28 +0100 >> > Vitaly Kuznetsov wrote: >> > >> >> Sometimes we'd like to know which features were explicitly enabled and >> >> which >> >> were e

Re: [PATCH v4 16/21] i386: track explicit 'hv-*' features enablement/disablement

2021-02-12 Thread Igor Mammedov
On Fri, 12 Feb 2021 09:45:52 +0100 Vitaly Kuznetsov wrote: > Igor Mammedov writes: > > > On Wed, 10 Feb 2021 17:40:28 +0100 > > Vitaly Kuznetsov wrote: > > > >> Sometimes we'd like to know which features were explicitly enabled and > >> which > >> were explicitly disabled on the command lin

Re: [PATCH v4 16/21] i386: track explicit 'hv-*' features enablement/disablement

2021-02-12 Thread Vitaly Kuznetsov
Igor Mammedov writes: > On Wed, 10 Feb 2021 17:40:28 +0100 > Vitaly Kuznetsov wrote: > >> Sometimes we'd like to know which features were explicitly enabled and which >> were explicitly disabled on the command line. E.g. it seems logical to handle >> 'hv_passthrough,hv_feature=off' as "enable ev

Re: [PATCH v4 16/21] i386: track explicit 'hv-*' features enablement/disablement

2021-02-11 Thread Igor Mammedov
On Wed, 10 Feb 2021 17:40:28 +0100 Vitaly Kuznetsov wrote: > Sometimes we'd like to know which features were explicitly enabled and which > were explicitly disabled on the command line. E.g. it seems logical to handle > 'hv_passthrough,hv_feature=off' as "enable everything supported by the host >

[PATCH v4 16/21] i386: track explicit 'hv-*' features enablement/disablement

2021-02-10 Thread Vitaly Kuznetsov
Sometimes we'd like to know which features were explicitly enabled and which were explicitly disabled on the command line. E.g. it seems logical to handle 'hv_passthrough,hv_feature=off' as "enable everything supported by the host except for hv_feature" but this doesn't seem to be possible with the