Re: [PATCH v4 17/37] mips: inline serial_init()

2019-11-27 Thread Aleksandar Markovic
On Wednesday, November 20, 2019, Marc-André Lureau < marcandre.lur...@redhat.com> wrote: > The function is specific to mipssim, let's inline it. > > Signed-off-by: Marc-André Lureau > --- > hw/char/serial.c | 16 > hw/mips/mips_mipssim.c | 15 --- > include

Re: [PATCH v4 17/37] mips: inline serial_init()

2019-11-25 Thread Marc-André Lureau
Hi On Mon, Nov 25, 2019 at 5:33 PM Aleksandar Markovic wrote: > > > > On Monday, November 25, 2019, Marc-André Lureau > wrote: >> >> Hi >> >> On Mon, Nov 25, 2019 at 2:12 PM Aleksandar Markovic >> wrote: >> > >> > >> > >> > On Wednesday, November 20, 2019, Marc-André Lureau >> > wrote: >> >>

Re: [PATCH v4 17/37] mips: inline serial_init()

2019-11-25 Thread Aleksandar Markovic
On Monday, November 25, 2019, Marc-André Lureau wrote: > Hi > > On Mon, Nov 25, 2019 at 2:12 PM Aleksandar Markovic > wrote: > > > > > > > > On Wednesday, November 20, 2019, Marc-André Lureau < > marcandre.lur...@redhat.com> wrote: > >> > >> The function is specific to mipssim, let's inline it.

Re: [PATCH v4 17/37] mips: inline serial_init()

2019-11-25 Thread Marc-André Lureau
Hi On Mon, Nov 25, 2019 at 2:12 PM Aleksandar Markovic wrote: > > > > On Wednesday, November 20, 2019, Marc-André Lureau > wrote: >> >> The function is specific to mipssim, let's inline it. >> >> Signed-off-by: Marc-André Lureau >> --- >> hw/char/serial.c | 16 >> hw/

Re: [PATCH v4 17/37] mips: inline serial_init()

2019-11-25 Thread Aleksandar Markovic
On Wednesday, November 20, 2019, Marc-André Lureau < marcandre.lur...@redhat.com> wrote: > The function is specific to mipssim, let's inline it. > > Signed-off-by: Marc-André Lureau > --- > hw/char/serial.c | 16 > hw/mips/mips_mipssim.c | 15 --- > include

Re: [PATCH v4 17/37] mips: inline serial_init()

2019-11-20 Thread Philippe Mathieu-Daudé
On 11/20/19 4:24 PM, Marc-André Lureau wrote: The function is specific to mipssim, let's inline it. Signed-off-by: Marc-André Lureau --- hw/char/serial.c | 16 hw/mips/mips_mipssim.c | 15 --- include/hw/char/serial.h | 2 -- 3 files changed, 12 inse

[PATCH v4 17/37] mips: inline serial_init()

2019-11-20 Thread Marc-André Lureau
The function is specific to mipssim, let's inline it. Signed-off-by: Marc-André Lureau --- hw/char/serial.c | 16 hw/mips/mips_mipssim.c | 15 --- include/hw/char/serial.h | 2 -- 3 files changed, 12 insertions(+), 21 deletions(-) diff --git a/hw/char/ser