Re: [PATCH v4 19/45] target/arm: Implement SME MOVA

2022-07-04 Thread Richard Henderson
On 7/4/22 15:01, Peter Maydell wrote: Columns will not be 8-aligned. On page 38 of 0616A.a, see the illustration of ZA0V.B[22], which is 6 mod 8. Yes, but the column slice number isn't part of offset, it's in index, so (contra the comment) you could do the xor before the "add offset to

Re: [PATCH v4 19/45] target/arm: Implement SME MOVA

2022-07-04 Thread Peter Maydell
On Mon, 4 Jul 2022 at 10:08, Richard Henderson wrote: > > On 7/1/22 21:49, Peter Maydell wrote: > > On Tue, 28 Jun 2022 at 05:40, Richard Henderson > > wrote: > >> > >> We can reuse the SVE functions for implementing moves to/from > >> horizontal tile slices, but we need new ones for moves

Re: [PATCH v4 19/45] target/arm: Implement SME MOVA

2022-07-04 Thread Richard Henderson
On 7/1/22 21:49, Peter Maydell wrote: On Tue, 28 Jun 2022 at 05:40, Richard Henderson wrote: We can reuse the SVE functions for implementing moves to/from horizontal tile slices, but we need new ones for moves to/from vertical tile slices. Signed-off-by: Richard Henderson --- diff --git

Re: [PATCH v4 19/45] target/arm: Implement SME MOVA

2022-07-01 Thread Peter Maydell
On Tue, 28 Jun 2022 at 05:40, Richard Henderson wrote: > > We can reuse the SVE functions for implementing moves to/from > horizontal tile slices, but we need new ones for moves to/from > vertical tile slices. > > Signed-off-by: Richard Henderson > --- > diff --git a/target/arm/sme_helper.c

[PATCH v4 19/45] target/arm: Implement SME MOVA

2022-06-27 Thread Richard Henderson
We can reuse the SVE functions for implementing moves to/from horizontal tile slices, but we need new ones for moves to/from vertical tile slices. Signed-off-by: Richard Henderson --- target/arm/helper-sme.h| 12 target/arm/helper-sve.h| 2 + target/arm/translate-a64.h | 8 +++