Re: [PATCH v4 2/2] migration: prevent migration when a poisoned page is unknown from the VM

2023-11-10 Thread William Roche
On 11/8/23 22:45, Peter Xu wrote: On Mon, Nov 06, 2023 at 10:38:14PM +0100, William Roche wrote: But it implies a lot of other changes:     - The source has to flag the error pages to indicate a poison   (new flag in the exchange protocole)     - The destination has to be able to deal

Re: [PATCH v4 2/2] migration: prevent migration when a poisoned page is unknown from the VM

2023-11-08 Thread Peter Xu
On Mon, Nov 06, 2023 at 10:38:14PM +0100, William Roche wrote: > Note also that large pages are taken into account too for our live > migration, but the poisoning of a qemu large page requires more work > especially for VM using standard 4k pages on top of these qemu large > pages -- and this is a

Re: [PATCH v4 2/2] migration: prevent migration when a poisoned page is unknown from the VM

2023-11-06 Thread William Roche
On 10/17/23 17:13, Peter Xu wrote: On Tue, Oct 17, 2023 at 02:38:48AM +0200, William Roche wrote: On 10/16/23 18:48, Peter Xu wrote: On Fri, Oct 13, 2023 at 03:08:39PM +, “William Roche wrote: diff --git a/target/arm/kvm64.c b/target/arm/kvm64.c index 5e95c496bb..e8db6380c1 100644 ---

Re: [PATCH v4 2/2] migration: prevent migration when a poisoned page is unknown from the VM

2023-10-17 Thread Peter Xu
On Tue, Oct 17, 2023 at 02:38:48AM +0200, William Roche wrote: > On 10/16/23 18:48, Peter Xu wrote: > > On Fri, Oct 13, 2023 at 03:08:39PM +, “William Roche wrote: > > > diff --git a/target/arm/kvm64.c b/target/arm/kvm64.c > > > index 5e95c496bb..e8db6380c1 100644 > > > ---

Re: [PATCH v4 2/2] migration: prevent migration when a poisoned page is unknown from the VM

2023-10-16 Thread William Roche
On 10/16/23 18:48, Peter Xu wrote: On Fri, Oct 13, 2023 at 03:08:39PM +, “William Roche wrote: diff --git a/target/arm/kvm64.c b/target/arm/kvm64.c index 5e95c496bb..e8db6380c1 100644 --- a/target/arm/kvm64.c +++ b/target/arm/kvm64.c @@ -1158,7 +1158,6 @@ void

Re: [PATCH v4 2/2] migration: prevent migration when a poisoned page is unknown from the VM

2023-10-16 Thread Peter Xu
On Fri, Oct 13, 2023 at 03:08:39PM +, “William Roche wrote: > diff --git a/target/arm/kvm64.c b/target/arm/kvm64.c > index 5e95c496bb..e8db6380c1 100644 > --- a/target/arm/kvm64.c > +++ b/target/arm/kvm64.c > @@ -1158,7 +1158,6 @@ void kvm_arch_on_sigbus_vcpu(CPUState *c, int code, > void

[PATCH v4 2/2] migration: prevent migration when a poisoned page is unknown from the VM

2023-10-13 Thread “William Roche
From: William Roche Migrating a poisoned page as a zero-page can only be done when the running guest kernel knows about this poison, so that it marks this page as unaccessible and any access in the VM would fail. But if a poison information is not relayed to the VM, the kernel does not prevent