Re: [PATCH v4 2/2] target/arm: kvm: Handle potential issue with dabt injection

2020-04-07 Thread Beata Michalska
On Tue, 7 Apr 2020 at 12:24, Peter Maydell wrote: > > On Fri, 3 Apr 2020 at 09:44, Andrew Jones wrote: > > > > On Mon, Mar 23, 2020 at 11:32:27AM +, Beata Michalska wrote: > > > Injecting external data abort through KVM might trigger > > > an issue on kernels that do not get updated to includ

Re: [PATCH v4 2/2] target/arm: kvm: Handle potential issue with dabt injection

2020-04-07 Thread Beata Michalska
On Fri, 3 Apr 2020 at 09:44, Andrew Jones wrote: > > On Mon, Mar 23, 2020 at 11:32:27AM +, Beata Michalska wrote: > > Injecting external data abort through KVM might trigger > > an issue on kernels that do not get updated to include the KVM fix. > > For those and aarch32 guests, the injected a

Re: [PATCH v4 2/2] target/arm: kvm: Handle potential issue with dabt injection

2020-04-07 Thread Peter Maydell
On Fri, 3 Apr 2020 at 09:44, Andrew Jones wrote: > > On Mon, Mar 23, 2020 at 11:32:27AM +, Beata Michalska wrote: > > Injecting external data abort through KVM might trigger > > an issue on kernels that do not get updated to include the KVM fix. > > For those and aarch32 guests, the injected a

Re: [PATCH v4 2/2] target/arm: kvm: Handle potential issue with dabt injection

2020-04-03 Thread Andrew Jones
On Mon, Mar 23, 2020 at 11:32:27AM +, Beata Michalska wrote: > Injecting external data abort through KVM might trigger > an issue on kernels that do not get updated to include the KVM fix. > For those and aarch32 guests, the injected abort gets misconfigured > to be an implementation defined ex

Re: [PATCH v4 2/2] target/arm: kvm: Handle potential issue with dabt injection

2020-03-25 Thread Beata Michalska
On Mon, 23 Mar 2020 at 18:44, Richard Henderson wrote: > > On 3/23/20 4:32 AM, Beata Michalska wrote: > > uint8_t ext_dabt_pending; /* Request for injecting ext DABT */ > > +uint8_t ext_dabt_raised; /* Tracking/verifying injection of ext DABT */ > > Is there a reason these are uint8_t and

Re: [PATCH v4 2/2] target/arm: kvm: Handle potential issue with dabt injection

2020-03-23 Thread Richard Henderson
On 3/23/20 4:32 AM, Beata Michalska wrote: > uint8_t ext_dabt_pending; /* Request for injecting ext DABT */ > +uint8_t ext_dabt_raised; /* Tracking/verifying injection of ext DABT */ Is there a reason these are uint8_t and not bool? r~

[PATCH v4 2/2] target/arm: kvm: Handle potential issue with dabt injection

2020-03-23 Thread Beata Michalska
Injecting external data abort through KVM might trigger an issue on kernels that do not get updated to include the KVM fix. For those and aarch32 guests, the injected abort gets misconfigured to be an implementation defined exception. This leads to the guest repeatedly re-running the faulting instr