Re: [PATCH v4 2/4] QIOChannelSocket: Fix zero-copy send so socket flush works

2022-06-20 Thread Peter Xu
On Mon, Jun 20, 2022 at 02:39:43AM -0300, Leonardo Bras wrote: > Somewhere between v6 and v7 the of the zero-copy-send patchset a crucial > part of the flushing mechanism got missing: incrementing zero_copy_queued. > > Without that, the flushing interface becomes a no-op, and there is no > guarant

Re: [PATCH v4 2/4] QIOChannelSocket: Fix zero-copy send so socket flush works

2022-06-20 Thread Juan Quintela
Leonardo Bras wrote: > Somewhere between v6 and v7 the of the zero-copy-send patchset a crucial > part of the flushing mechanism got missing: incrementing zero_copy_queued. > > Without that, the flushing interface becomes a no-op, and there is no > guarantee the buffer is really sent. > > This can

[PATCH v4 2/4] QIOChannelSocket: Fix zero-copy send so socket flush works

2022-06-19 Thread Leonardo Bras
Somewhere between v6 and v7 the of the zero-copy-send patchset a crucial part of the flushing mechanism got missing: incrementing zero_copy_queued. Without that, the flushing interface becomes a no-op, and there is no guarantee the buffer is really sent. This can go as bad as causing a corruption