Re: [PATCH v4 24/47] target/ppc: move vrl[bhwd]nm/vrl[bhwd]mi to decodetree

2022-02-24 Thread Richard Henderson
On 2/24/22 10:23, Matheus K. Ferst wrote: You don't want to use tcg_gen_rotlv_vec directly, but tcg_gen_rotlv_vec. I guess there is a typo here. Did you mean tcg_gen_gvec_rotlv? Or tcg_gen_rotlv_mod_vec? Dangit. Paste-paste error. The first: tcg_gen_gvec_rotlv. r~

Re: [PATCH v4 24/47] target/ppc: move vrl[bhwd]nm/vrl[bhwd]mi to decodetree

2022-02-24 Thread Matheus K. Ferst
On 23/02/2022 19:19, Richard Henderson wrote: On 2/23/22 11:43, Matheus K. Ferst wrote: Note that rotlv does the masking itself: /*   * Expand D = A << (B % element bits)   *   * Unlike scalar shifts, where it is easy for the target front end   * to include the modulo as part of the expansion. 

Re: [PATCH v4 24/47] target/ppc: move vrl[bhwd]nm/vrl[bhwd]mi to decodetree

2022-02-23 Thread Richard Henderson
On 2/23/22 11:43, Matheus K. Ferst wrote: Note that rotlv does the masking itself: /*   * Expand D = A << (B % element bits)   *   * Unlike scalar shifts, where it is easy for the target front end   * to include the modulo as part of the expansion.  If the target   * naturally includes the modul

Re: [PATCH v4 24/47] target/ppc: move vrl[bhwd]nm/vrl[bhwd]mi to decodetree

2022-02-23 Thread Matheus K. Ferst
On 22/02/2022 19:30, Richard Henderson wrote: On 2/22/22 04:36, matheus.fe...@eldorado.org.br wrote: +static void gen_vrlnm_vec(unsigned vece, TCGv_vec vrt, TCGv_vec vra, +  TCGv_vec vrb) +{ +    TCGv_vec mask, n = tcg_temp_new_vec_matching(vrt); + +    /* Create the mask

Re: [PATCH v4 24/47] target/ppc: move vrl[bhwd]nm/vrl[bhwd]mi to decodetree

2022-02-22 Thread Richard Henderson
On 2/22/22 04:36, matheus.fe...@eldorado.org.br wrote: +static void gen_vrlnm_vec(unsigned vece, TCGv_vec vrt, TCGv_vec vra, + TCGv_vec vrb) +{ +TCGv_vec mask, n = tcg_temp_new_vec_matching(vrt); + +/* Create the mask */ +mask = do_vrl_mask_vec(vece, vrb); + +

[PATCH v4 24/47] target/ppc: move vrl[bhwd]nm/vrl[bhwd]mi to decodetree

2022-02-22 Thread matheus . ferst
From: Matheus Ferst Signed-off-by: Matheus Ferst --- v4: - New in v4. --- target/ppc/helper.h | 8 +- target/ppc/insn32.decode| 6 ++ target/ppc/int_helper.c | 50 - target/ppc/translate/vmx-impl.c.inc | 152 ++-- ta