Re: [PATCH v4 29/31] hw/i386/sev: Allow use of pflash in conjunction with -bios

2024-06-04 Thread Hoffmann, Gerd
On Mon, Jun 03, 2024 at 03:38:05PM GMT, Paolo Bonzini wrote: > On Mon, Jun 3, 2024 at 1:55 PM Daniel P. Berrangé wrote: > > I really wish we didn't have to introduce this though - is there really > > no way to make it possible to use pflash for both CODE & VARS with SNP, > > as is done with tradit

Re: [PATCH v4 29/31] hw/i386/sev: Allow use of pflash in conjunction with -bios

2024-06-03 Thread Michael Roth
On Mon, Jun 03, 2024 at 04:31:45PM +0200, Paolo Bonzini wrote: > On Mon, Jun 3, 2024 at 4:28 PM Michael Roth wrote: > > So for now maybe we should plan to drop it from qemu-coco-queue and > > focus on the stateless builds for the initial code merge. > > Yes, I included it in qemu-coco-queue to en

Re: [PATCH v4 29/31] hw/i386/sev: Allow use of pflash in conjunction with -bios

2024-06-03 Thread Paolo Bonzini
On Mon, Jun 3, 2024 at 4:28 PM Michael Roth wrote: > So for now maybe we should plan to drop it from qemu-coco-queue and > focus on the stateless builds for the initial code merge. Yes, I included it in qemu-coco-queue to ensure that other things didn't break split firmware (or they were properly

Re: [PATCH v4 29/31] hw/i386/sev: Allow use of pflash in conjunction with -bios

2024-06-03 Thread Michael Roth via
On Mon, Jun 03, 2024 at 12:55:43PM +0100, Daniel P. Berrangé wrote: > On Thu, May 30, 2024 at 06:16:41AM -0500, Pankaj Gupta wrote: > > From: Michael Roth > > > > SEV-ES and SEV-SNP support OVMF images with non-volatile storage in > > cases where the storage area is generated as a separate image

Re: [PATCH v4 29/31] hw/i386/sev: Allow use of pflash in conjunction with -bios

2024-06-03 Thread Paolo Bonzini
On Mon, Jun 3, 2024 at 1:55 PM Daniel P. Berrangé wrote: > I really wish we didn't have to introduce this though - is there really > no way to make it possible to use pflash for both CODE & VARS with SNP, > as is done with traditional VMs, so we don't diverge in setup, needing > yet more changes u

Re: [PATCH v4 29/31] hw/i386/sev: Allow use of pflash in conjunction with -bios

2024-06-03 Thread Daniel P . Berrangé
On Thu, May 30, 2024 at 06:16:41AM -0500, Pankaj Gupta wrote: > From: Michael Roth > > SEV-ES and SEV-SNP support OVMF images with non-volatile storage in > cases where the storage area is generated as a separate image as part > of the OVMF build process. IIUC, right now all OVMF builds for SEV/

Re: [PATCH v4 29/31] hw/i386/sev: Allow use of pflash in conjunction with -bios

2024-05-31 Thread Paolo Bonzini
On Thu, May 30, 2024 at 1:17 PM Pankaj Gupta wrote: > diff --git a/hw/i386/pc_sysfw.c b/hw/i386/pc_sysfw.c > index def77a4429fb24e62748 > +static void pc_system_flash_map(PCMachineState *pcms, > +MemoryRegion *rom_memory) > +{ > +pc_system_flash_map_partial(pcms

[PATCH v4 29/31] hw/i386/sev: Allow use of pflash in conjunction with -bios

2024-05-30 Thread Pankaj Gupta
From: Michael Roth SEV-ES and SEV-SNP support OVMF images with non-volatile storage in cases where the storage area is generated as a separate image as part of the OVMF build process. Currently these are exposed with unit=0 corresponding to the actual BIOS image, and unit=1 corresponding to the