Re: [PATCH v4 29/47] hw/arm/stellaris: use qemu_find_nic_info()

2024-01-31 Thread Peter Maydell
On Wed, 31 Jan 2024 at 12:14, Thomas Huth wrote: > > On 26/01/2024 18.25, David Woodhouse wrote: > > From: David Woodhouse > > > > Rather than just using qemu_configure_nic_device(), populate the MAC > > address in the system-registers device by peeking at the NICInfo before > > it's assigned to

Re: [PATCH v4 29/47] hw/arm/stellaris: use qemu_find_nic_info()

2024-01-31 Thread David Woodhouse
On Wed, 2024-01-31 at 13:13 +0100, Thomas Huth wrote: > > >    qdev_prop_set_uint32(ssys_dev, "user0", > > - macaddr[0] | (macaddr[1] << 8) | (macaddr[2] << > > 16)); > > + mac.a[0] | (mac.a[1] << 8) | (mac.a[2] << 16)); > >   

Re: [PATCH v4 29/47] hw/arm/stellaris: use qemu_find_nic_info()

2024-01-31 Thread Thomas Huth
On 26/01/2024 18.25, David Woodhouse wrote: From: David Woodhouse Rather than just using qemu_configure_nic_device(), populate the MAC address in the system-registers device by peeking at the NICInfo before it's assigned to the device. Generate the MAC address early, if there is no matching

[PATCH v4 29/47] hw/arm/stellaris: use qemu_find_nic_info()

2024-01-26 Thread David Woodhouse
From: David Woodhouse Rather than just using qemu_configure_nic_device(), populate the MAC address in the system-registers device by peeking at the NICInfo before it's assigned to the device. Generate the MAC address early, if there is no matching -nic option. Otherwise the MAC address wouldn't