> -Original Message-
> From: Lukas Straub
> Sent: Friday, May 8, 2020 3:56 PM
> To: Zhang, Chen
> Cc: qemu-devel ; Li Zhijian
> ; Jason Wang ; Marc-
> André Lureau ; Paolo Bonzini
>
> Subject: Re: [PATCH v4 3/6] net/colo-compare.c: Fix deadlock in
> compa
; Paolo Bonzini
> >
> > Subject: Re: [PATCH v4 3/6] net/colo-compare.c: Fix deadlock in
> > compare_chr_send
> >
> > On Fri, 8 May 2020 02:19:00 +
> > "Zhang, Chen" wrote:
> > > > > No need to init the notify_sendco each time, bec
> -Original Message-
> From: Lukas Straub
> Sent: Friday, May 8, 2020 2:08 PM
> To: Zhang, Chen
> Cc: qemu-devel ; Li Zhijian
> ; Jason Wang ; Marc-
> André Lureau ; Paolo Bonzini
>
> Subject: Re: [PATCH v4 3/6] net/colo-compare.c: Fix deadlock in
> c
On Fri, 8 May 2020 02:19:00 +
"Zhang, Chen" wrote:
> > > No need to init the notify_sendco each time, because the notify dev just
> > an optional parameter.
> > > You can use the if (s->notify_dev) here. Just Xen use the chr_notify_dev.
> > >
> >
> > Ok, I will change that and the
> -Original Message-
> From: Lukas Straub
> Sent: Thursday, May 7, 2020 11:51 PM
> To: Zhang, Chen
> Cc: qemu-devel ; Li Zhijian
> ; Jason Wang ; Marc-
> André Lureau ; Paolo Bonzini
>
> Subject: Re: [PATCH v4 3/6] net/colo-compare.c: Fix deadlock in
> c
eau ; Paolo Bonzini
> >
> > Subject: [PATCH v4 3/6] net/colo-compare.c: Fix deadlock in
> > compare_chr_send
> >
> > The chr_out chardev is connected to a filter-redirector running in the
> > main loop. qemu_chr_fe_write_all might block here in compare_chr_sen
> -Original Message-
> From: Lukas Straub
> Sent: Monday, May 4, 2020 6:28 PM
> To: qemu-devel
> Cc: Zhang, Chen ; Li Zhijian
> ; Jason Wang ; Marc-
> André Lureau ; Paolo Bonzini
>
> Subject: [PATCH v4 3/6] net/colo-compare.c: Fix deadlock in
> com
The chr_out chardev is connected to a filter-redirector
running in the main loop. qemu_chr_fe_write_all might block
here in compare_chr_send if the (socket-)buffer is full.
If another filter-redirector in the main loop want's to
send data to chr_pri_in it might also block if the buffer
is full.
