Re: [PATCH v4 33/47] hw/m68k/q800: use qemu_find_nic_info()

2024-02-01 Thread Peter Maydell
On Thu, 1 Feb 2024 at 16:07, David Woodhouse wrote: > > On Thu, 2024-02-01 at 11:30 +0100, Thomas Huth wrote: > > On 31/01/2024 15.18, David Woodhouse wrote: > > > On Wed, 2024-01-31 at 13:18 +0100, Thomas Huth wrote: > > > > Don't we have to change nd->macaddr.a[0 to 2] with this hard-coded > >

Re: [PATCH v4 33/47] hw/m68k/q800: use qemu_find_nic_info()

2024-02-01 Thread David Woodhouse
On Thu, 2024-02-01 at 11:30 +0100, Thomas Huth wrote: > On 31/01/2024 15.18, David Woodhouse wrote: > > On Wed, 2024-01-31 at 13:18 +0100, Thomas Huth wrote: > > > Don't we have to change nd->macaddr.a[0 to 2] with this hard-coded > > > MAC-prefix, too? > > > > I don't think so. > > > > We

Re: [PATCH v4 33/47] hw/m68k/q800: use qemu_find_nic_info()

2024-02-01 Thread Thomas Huth
On 31/01/2024 15.18, David Woodhouse wrote: On Wed, 2024-01-31 at 13:18 +0100, Thomas Huth wrote: @@ -386,14 +382,21 @@ static void q800_machine_init(MachineState *machine)     * 08:00:07 Apple     * (Q800 use the last one)     */ -    nd_table[0].macaddr.a[0] = 0x08; -   

Re: [PATCH v4 33/47] hw/m68k/q800: use qemu_find_nic_info()

2024-01-31 Thread David Woodhouse
On Wed, 2024-01-31 at 13:18 +0100, Thomas Huth wrote: > > > @@ -386,14 +382,21 @@ static void q800_machine_init(MachineState > > *machine) > >     * 08:00:07 Apple > >     * (Q800 use the last one) > >     */ > > -    nd_table[0].macaddr.a[0] = 0x08; > > -    nd_table[0].macaddr.a[1]

Re: [PATCH v4 33/47] hw/m68k/q800: use qemu_find_nic_info()

2024-01-31 Thread Thomas Huth
On 26/01/2024 18.25, David Woodhouse wrote: From: David Woodhouse If a corresponding NIC configuration was found, it will have a MAC address already assigned, so use that. Else, generate and assign a default one. Using qemu_find_nic_info() is simpler than the alternative of using

[PATCH v4 33/47] hw/m68k/q800: use qemu_find_nic_info()

2024-01-26 Thread David Woodhouse
From: David Woodhouse If a corresponding NIC configuration was found, it will have a MAC address already assigned, so use that. Else, generate and assign a default one. Using qemu_find_nic_info() is simpler than the alternative of using qemu_configure_nic_device() and then having to fetch the