RE: [PATCH v4 4/5] vfio/pci: Free resources when vfio_migration_realize fails

2023-06-29 Thread Duan, Zhenzhong
>-Original Message- >From: Joao Martins >Subject: Re: [PATCH v4 4/5] vfio/pci: Free resources when >vfio_migration_realize fails > >On 29/06/2023 09:40, Zhenzhong Duan wrote: >> When vfio_realize() succeeds, hot unplug will call vfio_exitfn() to >

Re: [PATCH v4 4/5] vfio/pci: Free resources when vfio_migration_realize fails

2023-06-29 Thread Cédric Le Goater
On 6/29/23 13:45, Joao Martins wrote: On 29/06/2023 09:40, Zhenzhong Duan wrote: When vfio_realize() succeeds, hot unplug will call vfio_exitfn() to free resources allocated in vfio_realize(); when vfio_realize() fails, vfio_exitfn() is never called and we need to free resources in

Re: [PATCH v4 4/5] vfio/pci: Free resources when vfio_migration_realize fails

2023-06-29 Thread Joao Martins
On 29/06/2023 09:40, Zhenzhong Duan wrote: > When vfio_realize() succeeds, hot unplug will call vfio_exitfn() > to free resources allocated in vfio_realize(); when vfio_realize() > fails, vfio_exitfn() is never called and we need to free resources > in vfio_realize(). > > In the case that

[PATCH v4 4/5] vfio/pci: Free resources when vfio_migration_realize fails

2023-06-29 Thread Zhenzhong Duan
When vfio_realize() succeeds, hot unplug will call vfio_exitfn() to free resources allocated in vfio_realize(); when vfio_realize() fails, vfio_exitfn() is never called and we need to free resources in vfio_realize(). In the case that vfio_migration_realize() fails, e.g: with -only-migratable &