Re: [PATCH v4 5/6] net/colo-compare.c, softmmu/vl.c: Check that colo-compare is active

2020-05-12 Thread Dr. David Alan Gilbert
; > From: Lukas Straub > > > > Sent: Thursday, May 7, 2020 11:54 PM > > > > To: Zhang, Chen > > > > Cc: qemu-devel ; Li Zhijian > > > > ; Jason Wang ; Marc- > > > > André Lureau ; Paolo Bonzini > > >

RE: [PATCH v4 5/6] net/colo-compare.c, softmmu/vl.c: Check that colo-compare is active

2020-05-11 Thread Zhang, Chen
> > > Cc: qemu-devel ; Li Zhijian > > > ; Jason Wang ; Marc- > > > André Lureau ; Paolo Bonzini > > > > > > Subject: Re: [PATCH v4 5/6] net/colo-compare.c, softmmu/vl.c: Check > > > that colo-compare is active > > > > > > On F

Re: [PATCH v4 5/6] net/colo-compare.c, softmmu/vl.c: Check that colo-compare is active

2020-05-09 Thread Lukas Straub
- > > > > From: Lukas Straub > > > > Sent: Thursday, May 7, 2020 11:54 PM > > > > To: Zhang, Chen > > > > Cc: qemu-devel ; Li Zhijian > > > > ; Jason Wang ; Marc- > > > > André Lureau ; Paolo Bonzini > > &

RE: [PATCH v4 5/6] net/colo-compare.c, softmmu/vl.c: Check that colo-compare is active

2020-05-08 Thread Zhang, Chen
> -Original Message- > From: Lukas Straub > Sent: Friday, May 8, 2020 2:11 PM > To: Zhang, Chen > Cc: qemu-devel ; Li Zhijian > ; Jason Wang ; Marc- > André Lureau ; Paolo Bonzini > > Subject: Re: [PATCH v4 5/6] net/colo-compare.c, softmmu/vl.c: Check th

Re: [PATCH v4 5/6] net/colo-compare.c, softmmu/vl.c: Check that colo-compare is active

2020-05-08 Thread Lukas Straub
> > > > From: Lukas Straub > > > > Sent: Monday, May 4, 2020 6:28 PM > > > > To: qemu-devel > > > > Cc: Zhang, Chen ; Li Zhijian > > > > ; Jason Wang ; Marc- > > > > André Lureau ; Paolo Bonzini > > > > >

Re: [PATCH v4 5/6] net/colo-compare.c, softmmu/vl.c: Check that colo-compare is active

2020-05-07 Thread Derek Su
On 2020/5/8 上午10:26, Zhang, Chen wrote: -Original Message- From: Lukas Straub Sent: Thursday, May 7, 2020 11:54 PM To: Zhang, Chen Cc: qemu-devel ; Li Zhijian ; Jason Wang ; Marc- André Lureau ; Paolo Bonzini Subject: Re: [PATCH v4 5/6] net/colo-compare.c, softmmu/vl.c: Check

RE: [PATCH v4 5/6] net/colo-compare.c, softmmu/vl.c: Check that colo-compare is active

2020-05-07 Thread Zhang, Chen
> -Original Message- > From: Lukas Straub > Sent: Thursday, May 7, 2020 11:54 PM > To: Zhang, Chen > Cc: qemu-devel ; Li Zhijian > ; Jason Wang ; Marc- > André Lureau ; Paolo Bonzini > > Subject: Re: [PATCH v4 5/6] net/colo-compare.c, softmmu/vl.c: Check th

Re: [PATCH v4 5/6] net/colo-compare.c, softmmu/vl.c: Check that colo-compare is active

2020-05-07 Thread Lukas Straub
; Paolo Bonzini > > > > Subject: [PATCH v4 5/6] net/colo-compare.c, softmmu/vl.c: Check that colo- > > compare is active > > > > If the colo-compare object is removed before failover and a checkpoint > > happens, qemu crashes because it tries to lock

RE: [PATCH v4 5/6] net/colo-compare.c, softmmu/vl.c: Check that colo-compare is active

2020-05-07 Thread Zhang, Chen
> -Original Message- > From: Lukas Straub > Sent: Monday, May 4, 2020 6:28 PM > To: qemu-devel > Cc: Zhang, Chen ; Li Zhijian > ; Jason Wang ; Marc- > André Lureau ; Paolo Bonzini > > Subject: [PATCH v4 5/6] net/colo-compare.c, softmmu/vl.c: Check tha

[PATCH v4 5/6] net/colo-compare.c, softmmu/vl.c: Check that colo-compare is active

2020-05-04 Thread Lukas Straub
If the colo-compare object is removed before failover and a checkpoint happens, qemu crashes because it tries to lock the destroyed event_mtx in colo_notify_compares_event. Fix this by checking if everything is initialized by introducing a new variable colo_compare_active which is protected by a